Skip to content

Commit

Permalink
[PATCH] ioremap balanced with iounmap for drivers/pcmcia
Browse files Browse the repository at this point in the history
ioremap must be balanced by an iounmap and failing to do so can result
in a memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
  • Loading branch information
Amol Lad authored and Dominik Brodowski committed Oct 26, 2006
1 parent a230a67 commit 3efa997
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 6 deletions.
3 changes: 2 additions & 1 deletion drivers/pcmcia/at91_cf.c
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,10 @@ static int __init at91_cf_probe(struct platform_device *pdev)
return 0;

fail2:
iounmap((void __iomem *) cf->socket.io_offset);
release_mem_region(io->start, io->end + 1 - io->start);
fail1:
if (cf->socket.io_offset)
iounmap((void __iomem *) cf->socket.io_offset);
if (board->irq_pin)
free_irq(board->irq_pin, cf);
fail0a:
Expand Down
10 changes: 10 additions & 0 deletions drivers/pcmcia/au1000_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,16 @@ int au1x00_pcmcia_socket_probe(struct device *dev, struct pcmcia_low_level *ops,
del_timer_sync(&skt->poll_timer);
pcmcia_unregister_socket(&skt->socket);
flush_scheduled_work();
if (i == 0) {
iounmap(skt->virt_io + (u32)mips_io_port_base);
skt->virt_io = NULL;
}
#ifndef CONFIG_MIPS_XXS1500
else {
iounmap(skt->virt_io + (u32)mips_io_port_base);
skt->virt_io = NULL;
}
#endif
ops->hw_shutdown(skt);

}
Expand Down
12 changes: 8 additions & 4 deletions drivers/pcmcia/m8xx_pcmcia.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ static int voltage_set(int slot, int vcc, int vpp)
reg |= BCSR1_PCCVCC1;
break;
default:
return 1;
goto out_unmap;
}

switch(vpp) {
Expand All @@ -438,15 +438,15 @@ static int voltage_set(int slot, int vcc, int vpp)
if(vcc == vpp)
reg |= BCSR1_PCCVPP1;
else
return 1;
goto out_unmap;
break;
case 120:
if ((vcc == 33) || (vcc == 50))
reg |= BCSR1_PCCVPP0;
else
return 1;
goto out_unmap;
default:
return 1;
goto out_unmap;
}

/* first, turn off all power */
Expand All @@ -457,6 +457,10 @@ static int voltage_set(int slot, int vcc, int vpp)

iounmap(bcsr_io);
return 0;

out_unmap:
iounmap(bcsr_io);
return 1;
}

#define socket_get(_slot_) PCMCIA_SOCKET_KEY_5V
Expand Down
3 changes: 2 additions & 1 deletion drivers/pcmcia/omap_cf.c
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,10 @@ static int __devinit omap_cf_probe(struct device *dev)
return 0;

fail2:
iounmap((void __iomem *) cf->socket.io_offset);
release_mem_region(cf->phys_cf, SZ_8K);
fail1:
if (cf->socket.io_offset)
iounmap((void __iomem *) cf->socket.io_offset);
free_irq(irq, cf);
fail0:
kfree(cf);
Expand Down

0 comments on commit 3efa997

Please sign in to comment.