Skip to content

Commit

Permalink
net: fec: fix missing napi_disable call
Browse files Browse the repository at this point in the history
Commit dc97538 introduces napi support
but never calls napi_disable. This will generate a kernel oops
(kernel BUG at include/linux/netdevice.h:473!) every time, when
ndo_stop is called followed by ndo_start.
Add the missing napi_diable call.

Signed-off-by: Georg Hofmann <georg@hofmannsweb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Georg Hofmann authored and David S. Miller committed Mar 15, 2013
1 parent d97e749 commit 3f104c3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/freescale/fec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1441,6 +1441,7 @@ fec_enet_close(struct net_device *ndev)
struct fec_enet_private *fep = netdev_priv(ndev);

/* Don't know what to do yet. */
napi_disable(&fep->napi);
fep->opened = 0;
netif_stop_queue(ndev);
fec_stop(ndev);
Expand Down

0 comments on commit 3f104c3

Please sign in to comment.