Skip to content

Commit

Permalink
[SCSI] libfc: adds missing exch release for accepted RRQ
Browse files Browse the repository at this point in the history
Adds missing exch release when RRQ is accepted by calling
fc_seq_ls_acc. Adds common exch release for fc_exch_els_rrq
by use of out label.

Reported-by: Alex Lyakas <alexl@mellanox.co.il>
Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
  • Loading branch information
Vasu Dev authored and James Bottomley committed Dec 4, 2009
1 parent 89f19a5 commit 3f127ad
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/scsi/libfc/fc_exch.c
Original file line number Diff line number Diff line change
Expand Up @@ -1718,7 +1718,7 @@ static void fc_exch_rrq(struct fc_exch *ep)
*/
static void fc_exch_els_rrq(struct fc_seq *sp, struct fc_frame *fp)
{
struct fc_exch *ep; /* request or subject exchange */
struct fc_exch *ep = NULL; /* request or subject exchange */
struct fc_els_rrq *rp;
u32 sid;
u16 xid;
Expand Down Expand Up @@ -1768,15 +1768,16 @@ static void fc_exch_els_rrq(struct fc_seq *sp, struct fc_frame *fp)
* Send LS_ACC.
*/
fc_seq_ls_acc(sp);
fc_frame_free(fp);
return;
goto out;

unlock_reject:
spin_unlock_bh(&ep->ex_lock);
fc_exch_release(ep); /* drop hold from fc_exch_find */
reject:
fc_seq_ls_rjt(sp, ELS_RJT_LOGIC, explan);
out:
fc_frame_free(fp);
if (ep)
fc_exch_release(ep); /* drop hold from fc_exch_find */
}

struct fc_exch_mgr_anchor *fc_exch_mgr_add(struct fc_lport *lport,
Expand Down

0 comments on commit 3f127ad

Please sign in to comment.