Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 268671
b: refs/heads/master
c: ee2baa2
h: refs/heads/master
i:
  268669: 20fbaf6
  268667: b8b7086
  268663: 30c209c
  268655: 9a7ddb9
  268639: 443bbf6
  268607: 7e628ca
  268543: 2a4319e
v: v3
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed Oct 4, 2011
1 parent 103f224 commit 3f1ae0d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 52 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: c411f17daf0942509f6db47b4a237e953f35611b
refs/heads/master: ee2baa299ae11fec073c2b2aad7f6c571f71189e
54 changes: 3 additions & 51 deletions trunk/drivers/staging/hv/hv_mouse.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ struct mousevsc_prt_msg {
*/
struct mousevsc_dev {
struct hv_device *device;
/* 0 indicates the device is being destroyed */
atomic_t ref_count;
unsigned char init_complete;
struct mousevsc_prt_msg protocol_req;
struct mousevsc_prt_msg protocol_resp;
Expand All @@ -182,12 +180,6 @@ static struct mousevsc_dev *alloc_input_device(struct hv_device *device)
if (!input_dev)
return NULL;

/*
* Set to 2 to allow both inbound and outbound traffics
* (ie get_input_device() and must_get_input_device()) to proceed.
*/
atomic_set(&input_dev->ref_count, 2);

input_dev->device = device;
hv_set_drvdata(device, input_dev);
init_completion(&input_dev->wait_event);
Expand All @@ -203,32 +195,6 @@ static void free_input_device(struct mousevsc_dev *device)
kfree(device);
}

/*
* Get the inputdevice object iff exists and its refcount > 0
*/
static struct mousevsc_dev *must_get_input_device(struct hv_device *device)
{
struct mousevsc_dev *input_dev;

input_dev = hv_get_drvdata(device);

if (input_dev && atomic_read(&input_dev->ref_count))
atomic_inc(&input_dev->ref_count);
else
input_dev = NULL;

return input_dev;
}

static void put_input_device(struct hv_device *device)
{
struct mousevsc_dev *input_dev;

input_dev = hv_get_drvdata(device);

atomic_dec(&input_dev->ref_count);
}


static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
struct synthhid_device_info *device_info)
Expand Down Expand Up @@ -325,19 +291,13 @@ static void mousevsc_on_receive(struct hv_device *device,
{
struct pipe_prt_msg *pipe_msg;
struct synthhid_msg *hid_msg;
struct mousevsc_dev *input_dev;

input_dev = must_get_input_device(device);
if (!input_dev)
return;
struct mousevsc_dev *input_dev = hv_get_drvdata(device);

pipe_msg = (struct pipe_prt_msg *)((unsigned long)packet +
(packet->offset8 << 3));

if (pipe_msg->type != PipeMessageData) {
put_input_device(device);
return ;
}
if (pipe_msg->type != PipeMessageData)
return;

hid_msg = (struct synthhid_msg *)&pipe_msg->data[0];

Expand Down Expand Up @@ -370,15 +330,13 @@ static void mousevsc_on_receive(struct hv_device *device,
break;
}

put_input_device(device);
}

static void mousevsc_on_channel_callback(void *context)
{
const int packetSize = 0x100;
int ret = 0;
struct hv_device *device = (struct hv_device *)context;
struct mousevsc_dev *input_dev;

u32 bytes_recvd;
u64 req_id;
Expand All @@ -387,10 +345,6 @@ static void mousevsc_on_channel_callback(void *context)
unsigned char *buffer = packet;
int bufferlen = packetSize;

input_dev = must_get_input_device(device);

if (!input_dev)
return;

do {
ret = vmbus_recvpacket_raw(device->channel, buffer,
Expand Down Expand Up @@ -452,8 +406,6 @@ static void mousevsc_on_channel_callback(void *context)
}
} while (1);

put_input_device(device);

return;
}

Expand Down

0 comments on commit 3f1ae0d

Please sign in to comment.