Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 339403
b: refs/heads/master
c: 3e3f9f5
h: refs/heads/master
i:
  339401: 15e26e1
  339399: ec17f7f
v: v3
  • Loading branch information
Brian Foster authored and Ben Myers committed Nov 8, 2012
1 parent db12d17 commit 3f2c6b3
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 4 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8ca149de80478441352a8622ea15fae7de703ced
refs/heads/master: 3e3f9f5863548e870edfcc72e7617ac8ddcad44a
14 changes: 12 additions & 2 deletions trunk/fs/xfs/xfs_fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -346,13 +346,23 @@ typedef struct xfs_error_injection {
struct xfs_eofblocks {
__u32 eof_version;
__u32 eof_flags;
__u64 pad[15];
uid_t eof_uid;
gid_t eof_gid;
prid_t eof_prid;
__u32 pad32;
__u64 pad64[13];
};

/* eof_flags values */
#define XFS_EOF_FLAGS_SYNC (1 << 0) /* sync/wait mode scan */
#define XFS_EOF_FLAGS_UID (1 << 1) /* filter by uid */
#define XFS_EOF_FLAGS_GID (1 << 2) /* filter by gid */
#define XFS_EOF_FLAGS_PRID (1 << 3) /* filter by project id */
#define XFS_EOF_FLAGS_VALID \
(XFS_EOF_FLAGS_SYNC)
(XFS_EOF_FLAGS_SYNC | \
XFS_EOF_FLAGS_UID | \
XFS_EOF_FLAGS_GID | \
XFS_EOF_FLAGS_PRID)


/*
Expand Down
22 changes: 22 additions & 0 deletions trunk/fs/xfs/xfs_icache.c
Original file line number Diff line number Diff line change
Expand Up @@ -1170,6 +1170,21 @@ xfs_reclaim_inodes_count(
return reclaimable;
}

STATIC int
xfs_inode_match_id(
struct xfs_inode *ip,
struct xfs_eofblocks *eofb)
{
if (eofb->eof_flags & XFS_EOF_FLAGS_UID)
return ip->i_d.di_uid == eofb->eof_uid;
else if (eofb->eof_flags & XFS_EOF_FLAGS_GID)
return ip->i_d.di_gid == eofb->eof_gid;
else if (eofb->eof_flags & XFS_EOF_FLAGS_PRID)
return xfs_get_projid(ip) == eofb->eof_prid;

return 0;
}

STATIC int
xfs_inode_free_eofblocks(
struct xfs_inode *ip,
Expand All @@ -1178,6 +1193,7 @@ xfs_inode_free_eofblocks(
void *args)
{
int ret;
struct xfs_eofblocks *eofb = args;

if (!xfs_can_free_eofblocks(ip, false)) {
/* inode could be preallocated or append-only */
Expand All @@ -1194,6 +1210,12 @@ xfs_inode_free_eofblocks(
mapping_tagged(VFS_I(ip)->i_mapping, PAGECACHE_TAG_DIRTY))
return 0;

if (eofb &&
(eofb->eof_flags & (XFS_EOF_FLAGS_UID|XFS_EOF_FLAGS_GID|
XFS_EOF_FLAGS_PRID)) &&
!xfs_inode_match_id(ip, eofb))
return 0;

ret = xfs_free_eofblocks(ip->i_mount, ip, true);

/* don't revisit the inode if we're not waiting */
Expand Down
3 changes: 2 additions & 1 deletion trunk/fs/xfs/xfs_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1615,7 +1615,8 @@ xfs_file_ioctl(
if (eofb.eof_flags & ~XFS_EOF_FLAGS_VALID)
return -XFS_ERROR(EINVAL);

if (memchr_inv(eofb.pad, 0, sizeof(eofb.pad)))
if (memchr_inv(&eofb.pad32, 0, sizeof(eofb.pad32)) ||
memchr_inv(eofb.pad64, 0, sizeof(eofb.pad64)))
return -XFS_ERROR(EINVAL);

error = xfs_icache_free_eofblocks(mp, &eofb);
Expand Down

0 comments on commit 3f2c6b3

Please sign in to comment.