Skip to content

Commit

Permalink
spi: at25 driver is for EEPROM not FLASH
Browse files Browse the repository at this point in the history
Add comment to at25 driver that it's for EEPROM chips, not FLASH
chips ... the AT25 series has both types of chip, and sometimes
they're even pin-compatible.  The command sets are different, as
is the treatment of erasure.  (FLASH needs explicit erasure, but
with EEPROM it's implicit.)  Note that all vendors seem to have
this same confusion in their *25* series SPI memory parts.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
David Brownell authored and Linus Torvalds committed Dec 5, 2007
1 parent 068f407 commit 3f86f14
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/spi/at25.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@
#include <linux/spi/eeprom.h>


/*
* NOTE: this is an *EEPROM* driver. The vagaries of product naming
* mean that some AT25 products are EEPROMs, and others are FLASH.
* Handle FLASH chips with the drivers/mtd/devices/m25p80.c driver,
* not this one!
*/

struct at25_data {
struct spi_device *spi;
struct mutex lock;
Expand Down

0 comments on commit 3f86f14

Please sign in to comment.