Skip to content

Commit

Permalink
ARM: OMAP2+: PM debug: fix the use of debugfs_create_* API
Browse files Browse the repository at this point in the history
Check the return code pointer value from debugfs_create_dir for error
or NULL.
Also added an additional check to prevent the creation of a 'suspend'
entry at the debugfs root in case a power domain directory cannot be
created.

Signed-off-by: Jean Pihet <j-pihet@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
  • Loading branch information
Jean Pihet authored and Kevin Hilman committed Mar 5, 2012
1 parent 92206fd commit 401606f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/arm/mach-omap2/pm-debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *dir)
return 0;

d = debugfs_create_dir(pwrdm->name, (struct dentry *)dir);

(void) debugfs_create_file("suspend", S_IRUGO|S_IWUSR, d,
if (!(IS_ERR_OR_NULL(d)))
(void) debugfs_create_file("suspend", S_IRUGO|S_IWUSR, d,
(void *)pwrdm, &pwrdm_suspend_fops);

return 0;
Expand Down Expand Up @@ -264,7 +264,7 @@ static int __init pm_dbg_init(void)
return 0;

d = debugfs_create_dir("pm_debug", NULL);
if (IS_ERR(d))
if (IS_ERR_OR_NULL(d))
return PTR_ERR(d);

(void) debugfs_create_file("count", S_IRUGO,
Expand Down

0 comments on commit 401606f

Please sign in to comment.