Skip to content

Commit

Permalink
staging: tidspbridge: remove RET_OK RET_FAIL
Browse files Browse the repository at this point in the history 
RET_OK is 0 and RET_FAIL is a -1, replace these custom returns with
a standard errno

Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Nishanth Menon authored and Greg Kroah-Hartman committed Jul 22, 2010
1 parent 7124cb1 commit 4018e39
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 32 deletions.
10 changes: 4 additions & 6 deletions drivers/staging/tidspbridge/core/tiomap3430.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1506,8 +1506,7 @@ static int bridge_brd_mem_un_map(struct bridge_dev_context *dev_ctxt,
}
paddr += HW_PAGE_SIZE4KB;
}
if (hw_mmu_pte_clear(pte_addr_l2, va_curr, pte_size)
== RET_FAIL) {
if (hw_mmu_pte_clear(pte_addr_l2, va_curr, pte_size)) {
status = -EPERM;
goto EXIT_LOOP;
}
Expand All @@ -1524,9 +1523,8 @@ static int bridge_brd_mem_un_map(struct bridge_dev_context *dev_ctxt,
/*
* Clear the L1 PTE pointing to the L2 PT
*/
if (hw_mmu_pte_clear(l1_base_va, va_curr_orig,
HW_MMU_COARSE_PAGE_SIZE) ==
RET_OK)
if (!hw_mmu_pte_clear(l1_base_va, va_curr_orig,
HW_MMU_COARSE_PAGE_SIZE))
status = 0;
else {
status = -EPERM;
Expand Down Expand Up @@ -1571,7 +1569,7 @@ static int bridge_brd_mem_un_map(struct bridge_dev_context *dev_ctxt,
}
paddr += HW_PAGE_SIZE4KB;
}
if (hw_mmu_pte_clear(l1_base_va, va_curr, pte_size) == RET_OK) {
if (!hw_mmu_pte_clear(l1_base_va, va_curr, pte_size)) {
status = 0;
rem_bytes -= pte_size;
va_curr += pte_size;
Expand Down
53 changes: 27 additions & 26 deletions drivers/staging/tidspbridge/hw/hw_mmu.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <hw_defs.h>
#include <hw_mmu.h>
#include <linux/types.h>
#include <linux/err.h>

#define MMU_BASE_VAL_MASK 0xFC00
#define MMU_PAGE_MAX 3
Expand Down Expand Up @@ -59,7 +60,7 @@ enum hw_mmu_page_size_t {
* RETURNS:
*
* Type : hw_status
* Description : RET_OK -- No errors occured
* Description : 0 -- No errors occured
* RET_BAD_NULL_PARAM -- A Pointer
* Paramater was set to NULL
*
Expand Down Expand Up @@ -102,7 +103,7 @@ static hw_status mmu_flush_entry(const void __iomem *base_address);
* RETURNS:
*
* Type : hw_status
* Description : RET_OK -- No errors occured
* Description : 0 -- No errors occured
* RET_BAD_NULL_PARAM -- A Pointer Paramater
* was set to NULL
* RET_PARAM_OUT_OF_RANGE -- Input Parameter out
Expand Down Expand Up @@ -147,7 +148,7 @@ static hw_status mmu_set_cam_entry(const void __iomem *base_address,
* RETURNS:
*
* Type : hw_status
* Description : RET_OK -- No errors occured
* Description : 0 -- No errors occured
* RET_BAD_NULL_PARAM -- A Pointer Paramater
* was set to NULL
* RET_PARAM_OUT_OF_RANGE -- Input Parameter
Expand All @@ -167,7 +168,7 @@ static hw_status mmu_set_ram_entry(const void __iomem *base_address,

hw_status hw_mmu_enable(const void __iomem *base_address)
{
hw_status status = RET_OK;
hw_status status = 0;

MMUMMU_CNTLMMU_ENABLE_WRITE32(base_address, HW_SET);

Expand All @@ -176,7 +177,7 @@ hw_status hw_mmu_enable(const void __iomem *base_address)

hw_status hw_mmu_disable(const void __iomem *base_address)
{
hw_status status = RET_OK;
hw_status status = 0;

MMUMMU_CNTLMMU_ENABLE_WRITE32(base_address, HW_CLEAR);

Expand All @@ -186,7 +187,7 @@ hw_status hw_mmu_disable(const void __iomem *base_address)
hw_status hw_mmu_num_locked_set(const void __iomem *base_address,
u32 num_locked_entries)
{
hw_status status = RET_OK;
hw_status status = 0;

MMUMMU_LOCK_BASE_VALUE_WRITE32(base_address, num_locked_entries);

Expand All @@ -196,7 +197,7 @@ hw_status hw_mmu_num_locked_set(const void __iomem *base_address,
hw_status hw_mmu_victim_num_set(const void __iomem *base_address,
u32 victim_entry_num)
{
hw_status status = RET_OK;
hw_status status = 0;

MMUMMU_LOCK_CURRENT_VICTIM_WRITE32(base_address, victim_entry_num);

Expand All @@ -205,7 +206,7 @@ hw_status hw_mmu_victim_num_set(const void __iomem *base_address,

hw_status hw_mmu_event_ack(const void __iomem *base_address, u32 irq_mask)
{
hw_status status = RET_OK;
hw_status status = 0;

MMUMMU_IRQSTATUS_WRITE_REGISTER32(base_address, irq_mask);

Expand All @@ -214,7 +215,7 @@ hw_status hw_mmu_event_ack(const void __iomem *base_address, u32 irq_mask)

hw_status hw_mmu_event_disable(const void __iomem *base_address, u32 irq_mask)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 irq_reg;

irq_reg = MMUMMU_IRQENABLE_READ_REGISTER32(base_address);
Expand All @@ -226,7 +227,7 @@ hw_status hw_mmu_event_disable(const void __iomem *base_address, u32 irq_mask)

hw_status hw_mmu_event_enable(const void __iomem *base_address, u32 irq_mask)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 irq_reg;

irq_reg = MMUMMU_IRQENABLE_READ_REGISTER32(base_address);
Expand All @@ -238,7 +239,7 @@ hw_status hw_mmu_event_enable(const void __iomem *base_address, u32 irq_mask)

hw_status hw_mmu_event_status(const void __iomem *base_address, u32 *irq_mask)
{
hw_status status = RET_OK;
hw_status status = 0;

*irq_mask = MMUMMU_IRQSTATUS_READ_REGISTER32(base_address);

Expand All @@ -247,7 +248,7 @@ hw_status hw_mmu_event_status(const void __iomem *base_address, u32 *irq_mask)

hw_status hw_mmu_fault_addr_read(const void __iomem *base_address, u32 *addr)
{
hw_status status = RET_OK;
hw_status status = 0;

/*Check the input Parameters */
CHECK_INPUT_PARAM(base_address, 0, RET_BAD_NULL_PARAM,
Expand All @@ -261,7 +262,7 @@ hw_status hw_mmu_fault_addr_read(const void __iomem *base_address, u32 *addr)

hw_status hw_mmu_ttb_set(const void __iomem *base_address, u32 ttb_phys_addr)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 load_ttb;

/*Check the input Parameters */
Expand All @@ -277,7 +278,7 @@ hw_status hw_mmu_ttb_set(const void __iomem *base_address, u32 ttb_phys_addr)

hw_status hw_mmu_twl_enable(const void __iomem *base_address)
{
hw_status status = RET_OK;
hw_status status = 0;

MMUMMU_CNTLTWL_ENABLE_WRITE32(base_address, HW_SET);

Expand All @@ -286,7 +287,7 @@ hw_status hw_mmu_twl_enable(const void __iomem *base_address)

hw_status hw_mmu_twl_disable(const void __iomem *base_address)
{
hw_status status = RET_OK;
hw_status status = 0;

MMUMMU_CNTLTWL_ENABLE_WRITE32(base_address, HW_CLEAR);

Expand All @@ -296,7 +297,7 @@ hw_status hw_mmu_twl_disable(const void __iomem *base_address)
hw_status hw_mmu_tlb_flush(const void __iomem *base_address, u32 virtual_addr,
u32 page_sz)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 virtual_addr_tag;
enum hw_mmu_page_size_t pg_size_bits;

Expand All @@ -318,7 +319,7 @@ hw_status hw_mmu_tlb_flush(const void __iomem *base_address, u32 virtual_addr,
break;

default:
return RET_FAIL;
return -EINVAL;
}

/* Generate the 20-bit tag from virtual address */
Expand All @@ -339,7 +340,7 @@ hw_status hw_mmu_tlb_add(const void __iomem *base_address,
struct hw_mmu_map_attrs_t *map_attrs,
s8 preserved_bit, s8 valid_bit)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 lock_reg;
u32 virtual_addr_tag;
enum hw_mmu_page_size_t mmu_pg_size;
Expand Down Expand Up @@ -371,7 +372,7 @@ hw_status hw_mmu_tlb_add(const void __iomem *base_address,
break;

default:
return RET_FAIL;
return -EINVAL;
}

lock_reg = MMUMMU_LOCK_READ_REGISTER32(base_address);
Expand Down Expand Up @@ -406,7 +407,7 @@ hw_status hw_mmu_pte_set(const u32 pg_tbl_va,
u32 virtual_addr,
u32 page_sz, struct hw_mmu_map_attrs_t *map_attrs)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 pte_addr, pte_val;
s32 num_entries = 1;

Expand Down Expand Up @@ -466,7 +467,7 @@ hw_status hw_mmu_pte_set(const u32 pg_tbl_va,
break;

default:
return RET_FAIL;
return -EINVAL;
}

while (--num_entries >= 0)
Expand All @@ -477,7 +478,7 @@ hw_status hw_mmu_pte_set(const u32 pg_tbl_va,

hw_status hw_mmu_pte_clear(const u32 pg_tbl_va, u32 virtual_addr, u32 page_size)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 pte_addr;
s32 num_entries = 1;

Expand Down Expand Up @@ -510,7 +511,7 @@ hw_status hw_mmu_pte_clear(const u32 pg_tbl_va, u32 virtual_addr, u32 page_size)
break;

default:
return RET_FAIL;
return -EINVAL;
}

while (--num_entries >= 0)
Expand All @@ -522,7 +523,7 @@ hw_status hw_mmu_pte_clear(const u32 pg_tbl_va, u32 virtual_addr, u32 page_size)
/* mmu_flush_entry */
static hw_status mmu_flush_entry(const void __iomem *base_address)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 flush_entry_data = 0x1;

/*Check the input Parameters */
Expand All @@ -542,7 +543,7 @@ static hw_status mmu_set_cam_entry(const void __iomem *base_address,
const u32 valid_bit,
const u32 virtual_addr_tag)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 mmu_cam_reg;

/*Check the input Parameters */
Expand All @@ -566,7 +567,7 @@ static hw_status mmu_set_ram_entry(const void __iomem *base_address,
enum hw_element_size_t element_size,
enum hw_mmu_mixed_size_t mixed_size)
{
hw_status status = RET_OK;
hw_status status = 0;
u32 mmu_ram_reg;

/*Check the input Parameters */
Expand Down

0 comments on commit 4018e39

Please sign in to comment.