Skip to content

Commit

Permalink
btrfs: usage error should not be logged into system log
Browse files Browse the repository at this point in the history
I have an opinion that system logs /var/log/messages are
valuable info to investigate the real system issues at
the data center. People handling data center issues
do spend a lot time and efforts analyzing messages
files. Having usage error logged into /var/log/messages
is something we should avoid.

Signed-off-by: Anand Jain <Anand.Jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>
  • Loading branch information
Anand Jain authored and Chris Mason committed Jun 10, 2014
1 parent 67a77eb commit 402a0f4
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fs/btrfs/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -374,11 +374,8 @@ static ssize_t btrfs_label_store(struct kobject *kobj,
struct btrfs_root *root = fs_info->fs_root;
int ret;

if (len >= BTRFS_LABEL_SIZE) {
pr_err("BTRFS: unable to set label with more than %d bytes\n",
BTRFS_LABEL_SIZE - 1);
if (len >= BTRFS_LABEL_SIZE)
return -EINVAL;
}

trans = btrfs_start_transaction(root, 0);
if (IS_ERR(trans))
Expand Down

0 comments on commit 402a0f4

Please sign in to comment.