Skip to content

Commit

Permalink
hwmon: (w83l785ts) Don't ask the user to report failures
Browse files Browse the repository at this point in the history
There's nothing we can do about read errors on the W83L785TS-S, so
don't ask the user to report them.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
  • Loading branch information
Jean Delvare authored and Mark M. Hoffman committed Apr 27, 2008
1 parent 4b119e2 commit 4040c41
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion Documentation/hwmon/w83l785ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ Known Issues
------------

On some systems (Asus), the BIOS is known to interfere with the driver
and cause read errors. The driver will retry a given number of times
and cause read errors. Or maybe the W83L785TS-S chip is simply unreliable,
we don't really know. The driver will retry a given number of times
(5 by default) and then give up, returning the old value (or 0 if
there is no old value). It seems to work well enough so that you should
not notice anything. Thanks to James Bolt for helping test this feature.
4 changes: 2 additions & 2 deletions drivers/hwmon/w83l785ts.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@ static u8 w83l785ts_read_value(struct i2c_client *client, u8 reg, u8 defval)
msleep(i);
}

dev_err(&client->dev, "Couldn't read value from register 0x%02x. "
"Please report.\n", reg);
dev_err(&client->dev, "Couldn't read value from register 0x%02x.\n",
reg);
return defval;
}

Expand Down

0 comments on commit 4040c41

Please sign in to comment.