Skip to content

Commit

Permalink
V4L/DVB (6715): ivtv: Remove unnecessary register update
Browse files Browse the repository at this point in the history
To reduce the number of display register accesses, the yuv code keeps track of
the current video settings. Should there be a change in any single parameter,
it will update the associated display registers to ensure everything is
displayed correctly.

The existing check also looks at the field order for the video. This is not
required, since field reversal does not require any display register changes.

This patch removes the field order from the check.

Signed-off-by: Ian Armstrong <ian@iarmst.demon.co.uk>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Ian Armstrong authored and Mauro Carvalho Chehab committed Jan 25, 2008
1 parent 166983c commit 406c8b0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/video/ivtv/ivtv-yuv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,7 @@ void ivtv_yuv_setup_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
yi->new_frame_info[frame].update = 0;
yi->new_frame_info[frame].interlaced_y = 0;
yi->new_frame_info[frame].interlaced_uv = 0;
yi->new_frame_info[frame].lace_mode = yi->lace_mode;
yi->new_frame_info[frame].lace_mode = yi->lace_mode & IVTV_YUV_MODE_MASK;

if (memcmp(&yi->old_frame_info_args, &yi->new_frame_info[frame],
sizeof(yi->new_frame_info[frame]))) {
Expand Down

0 comments on commit 406c8b0

Please sign in to comment.