Skip to content

Commit

Permalink
staging: brcm80211: fixed checkpatch warnings
Browse files Browse the repository at this point in the history
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alwin Beukers authored and Greg Kroah-Hartman committed Oct 5, 2011
1 parent ef8299d commit 406f8d6
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 14 deletions.
14 changes: 6 additions & 8 deletions drivers/staging/brcm80211/brcmsmac/aiutils.c
Original file line number Diff line number Diff line change
Expand Up @@ -1054,9 +1054,8 @@ static struct si_info *ai_doattach(struct si_info *sii,
cc = (struct chipcregs __iomem *) regs;

/* bus/core/clk setup for register access */
if (!ai_buscore_prep(sii)) {
if (!ai_buscore_prep(sii))
return NULL;
}

/*
* ChipID recognition.
Expand Down Expand Up @@ -1084,19 +1083,18 @@ static struct si_info *ai_doattach(struct si_info *sii,
return NULL;
}
/* no cores found, bail out */
if (sii->numcores == 0) {
if (sii->numcores == 0)
return NULL;
}

/* bus/core/clk setup */
origidx = SI_CC_IDX;
if (!ai_buscore_setup(sii, savewin, &origidx)) {
if (!ai_buscore_setup(sii, savewin, &origidx))
goto exit;
}

/* Init nvram from sprom/otp if they exist */
if (srom_var_init(&sii->pub, cc, vars, varsz)) {
if (srom_var_init(&sii->pub, cc, vars, varsz))
goto exit;
}

pvars = vars ? *vars : NULL;
ai_nvram_process(sii, pvars);

Expand Down
3 changes: 1 addition & 2 deletions drivers/staging/brcm80211/brcmsmac/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -5995,9 +5995,8 @@ int brcms_c_set_gmode(struct brcms_c_info *wlc, u8 gmode, bool config)
* If we are switching to gmode == GMODE_LEGACY_B,
* clean up rate info that may refer to OFDM rates.
*/
if ((gmode == GMODE_LEGACY_B) && (band->gmode != GMODE_LEGACY_B)) {
if ((gmode == GMODE_LEGACY_B) && (band->gmode != GMODE_LEGACY_B))
band->gmode = gmode;
}

band->gmode = gmode;

Expand Down
3 changes: 1 addition & 2 deletions drivers/staging/brcm80211/brcmsmac/nicpci.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,8 @@ static bool pcie_mdiosetblock(struct pcicore_info *pi, uint blk)
i++;
}

if (i >= pcie_serdes_spinwait) {
if (i >= pcie_serdes_spinwait)
return false;
}

return true;
}
Expand Down
3 changes: 1 addition & 2 deletions drivers/staging/brcm80211/brcmsmac/srom.c
Original file line number Diff line number Diff line change
Expand Up @@ -1175,8 +1175,7 @@ static int initvars_srom_pci(struct si_pub *sih, void __iomem *curmap,
if (sromrev == 0x10)
sromrev = 1;
}
}
else {
} else {
/* Use OTP if SPROM not available */
err = otp_read_pci(sih, srom, SROM_MAX);
if (err == 0)
Expand Down

0 comments on commit 406f8d6

Please sign in to comment.