Skip to content

Commit

Permalink
[CIFS] change misleading field name
Browse files Browse the repository at this point in the history
num_auth is really num_subauth in ACL terminology

Signed-off-by: Steve French <sfrench@us.ibm.com>
  • Loading branch information
Steve French committed Oct 1, 2007
1 parent 92ad9b9 commit 4084973
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
4 changes: 2 additions & 2 deletions fs/cifs/cifsacl.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ static int parse_sid(struct cifs_sid *psid, char *end_of_acl)
}
#ifdef CONFIG_CIFS_DEBUG2
cFYI(1, ("revision %d num_auth %d First subauth 0x%x",
psid->revision, psid->num_auth, psid->sub_auth[0]));
psid->revision, psid->num_subauth, psid->sub_auth[0]));

/* BB add length check to make sure that we do not have huge num auths
and therefore go off the end */
cFYI(1, ("RID 0x%x", le32_to_cpu(psid->sub_auth[psid->num_auth])));
cFYI(1, ("RID 0x%x", le32_to_cpu(psid->sub_auth[psid->num_subauth])));
#endif
return 0;
}
Expand Down
10 changes: 4 additions & 6 deletions fs/cifs/cifsacl.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ struct cifs_ntsd {

struct cifs_sid {
__u8 revision; /* revision level */
__u8 num_auth;
__u8 num_subauth;
__u8 authority[6];
__u32 sub_auth[4];
__u32 rid;
__u32 sub_auth[0]; /* sub_auth[num_subauth] */
} __attribute__((packed));

struct cifs_acl {
Expand All @@ -54,10 +53,9 @@ struct cifs_ntace {

struct cifs_ace {
__u8 revision; /* revision level */
__u8 num_auth;
__u8 num_subauth;
__u8 authority[6];
__u32 sub_auth[4];
__u32 rid;
__u32 sub_auth[0];
} __attribute__((packed));

/* everyone */
Expand Down

0 comments on commit 4084973

Please sign in to comment.