Skip to content

Commit

Permalink
[PATCH] make lots of things static
Browse files Browse the repository at this point in the history
Another large rollup of various patches from Adrian which make things static
where they were needlessly exported.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Adrian Bunk authored and Linus Torvalds committed May 1, 2005
1 parent c31403a commit 408b664
Show file tree
Hide file tree
Showing 33 changed files with 67 additions and 70 deletions.
4 changes: 2 additions & 2 deletions arch/i386/kernel/cpu/mtrr/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ int generic_get_free_region(unsigned long base, unsigned long size)
return -ENOSPC;
}

void generic_get_mtrr(unsigned int reg, unsigned long *base,
unsigned int *size, mtrr_type * type)
static void generic_get_mtrr(unsigned int reg, unsigned long *base,
unsigned int *size, mtrr_type * type)
{
unsigned int mask_lo, mask_hi, base_lo, base_hi;

Expand Down
2 changes: 1 addition & 1 deletion arch/x86_64/kernel/early_printk.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ static struct console early_vga_console = {

/* Serial functions loosely based on a similar package from Klaus P. Gerlicher */

int early_serial_base = 0x3f8; /* ttyS0 */
static int early_serial_base = 0x3f8; /* ttyS0 */

#define XMTRDY 0x20

Expand Down
4 changes: 2 additions & 2 deletions drivers/char/agp/ali-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ static struct aper_size_info_32 ali_generic_sizes[7] =
{4, 1024, 0, 3}
};

struct agp_bridge_driver ali_generic_bridge = {
static struct agp_bridge_driver ali_generic_bridge = {
.owner = THIS_MODULE,
.aperture_sizes = ali_generic_sizes,
.size_type = U32_APER_SIZE,
Expand All @@ -215,7 +215,7 @@ struct agp_bridge_driver ali_generic_bridge = {
.agp_destroy_page = ali_destroy_page,
};

struct agp_bridge_driver ali_m1541_bridge = {
static struct agp_bridge_driver ali_m1541_bridge = {
.owner = THIS_MODULE,
.aperture_sizes = ali_generic_sizes,
.size_type = U32_APER_SIZE,
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/agp/amd-k7-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ static struct gatt_mask amd_irongate_masks[] =
{.mask = 1, .type = 0}
};

struct agp_bridge_driver amd_irongate_driver = {
static struct agp_bridge_driver amd_irongate_driver = {
.owner = THIS_MODULE,
.aperture_sizes = amd_irongate_sizes,
.size_type = LVL2_APER_SIZE,
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/agp/amd64-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ static void amd64_cleanup(void)
}


struct agp_bridge_driver amd_8151_driver = {
static struct agp_bridge_driver amd_8151_driver = {
.owner = THIS_MODULE,
.aperture_sizes = amd_8151_sizes,
.size_type = U32_APER_SIZE,
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/agp/ati-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ static int ati_free_gatt_table(struct agp_bridge_data *bridge)
return 0;
}

struct agp_bridge_driver ati_generic_bridge = {
static struct agp_bridge_driver ati_generic_bridge = {
.owner = THIS_MODULE,
.aperture_sizes = ati_generic_sizes,
.size_type = LVL2_APER_SIZE,
Expand Down
4 changes: 2 additions & 2 deletions drivers/char/agp/backend.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ void agp_backend_release(struct agp_bridge_data *bridge)
EXPORT_SYMBOL(agp_backend_release);


struct { int mem, agp; } maxes_table[] = {
static struct { int mem, agp; } maxes_table[] = {
{0, 0},
{32, 4},
{64, 28},
Expand Down Expand Up @@ -322,7 +322,7 @@ static int __init agp_init(void)
return 0;
}

void __exit agp_exit(void)
static void __exit agp_exit(void)
{
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/char/agp/efficeon-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ static int efficeon_remove_memory(struct agp_memory * mem, off_t pg_start, int t
}


struct agp_bridge_driver efficeon_driver = {
static struct agp_bridge_driver efficeon_driver = {
.owner = THIS_MODULE,
.aperture_sizes = efficeon_generic_sizes,
.size_type = LVL2_APER_SIZE,
Expand Down
6 changes: 3 additions & 3 deletions drivers/char/agp/frontend.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ static void agp_insert_into_pool(struct agp_memory * temp)

/* File private list routines */

struct agp_file_private *agp_find_private(pid_t pid)
static struct agp_file_private *agp_find_private(pid_t pid)
{
struct agp_file_private *curr;

Expand All @@ -250,7 +250,7 @@ struct agp_file_private *agp_find_private(pid_t pid)
return NULL;
}

void agp_insert_file_private(struct agp_file_private * priv)
static void agp_insert_file_private(struct agp_file_private * priv)
{
struct agp_file_private *prev;

Expand All @@ -262,7 +262,7 @@ void agp_insert_file_private(struct agp_file_private * priv)
agp_fe.file_priv_list = priv;
}

void agp_remove_file_private(struct agp_file_private * priv)
static void agp_remove_file_private(struct agp_file_private * priv)
{
struct agp_file_private *next;
struct agp_file_private *prev;
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/agp/nvidia-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ static struct gatt_mask nvidia_generic_masks[] =
};


struct agp_bridge_driver nvidia_driver = {
static struct agp_bridge_driver nvidia_driver = {
.owner = THIS_MODULE,
.aperture_sizes = nvidia_generic_sizes,
.size_type = U8_APER_SIZE,
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/agp/sis-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ static struct aper_size_info_8 sis_generic_sizes[7] =
{4, 1024, 0, 3}
};

struct agp_bridge_driver sis_driver = {
static struct agp_bridge_driver sis_driver = {
.owner = THIS_MODULE,
.aperture_sizes = sis_generic_sizes,
.size_type = U8_APER_SIZE,
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/agp/sworks-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ static void serverworks_agp_enable(struct agp_bridge_data *bridge, u32 mode)
agp_device_command(command, 0);
}

struct agp_bridge_driver sworks_driver = {
static struct agp_bridge_driver sworks_driver = {
.owner = THIS_MODULE,
.aperture_sizes = serverworks_sizes,
.size_type = LVL2_APER_SIZE,
Expand Down
4 changes: 2 additions & 2 deletions drivers/char/agp/via-agp.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ static void via_tlbflush_agp3(struct agp_memory *mem)
}


struct agp_bridge_driver via_agp3_driver = {
static struct agp_bridge_driver via_agp3_driver = {
.owner = THIS_MODULE,
.aperture_sizes = agp3_generic_sizes,
.size_type = U8_APER_SIZE,
Expand All @@ -193,7 +193,7 @@ struct agp_bridge_driver via_agp3_driver = {
.agp_destroy_page = agp_generic_destroy_page,
};

struct agp_bridge_driver via_driver = {
static struct agp_bridge_driver via_driver = {
.owner = THIS_MODULE,
.aperture_sizes = via_generic_sizes,
.size_type = U8_APER_SIZE,
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/rio/rio_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ static int rio_probe_addrs[]= {0xc0000, 0xd0000, 0xe0000};
/* Set the mask to all-ones. This alas, only supports 32 interrupts.
Some architectures may need more. -- Changed to LONG to
support up to 64 bits on 64bit architectures. -- REW 20/06/99 */
long rio_irqmask = -1;
static long rio_irqmask = -1;

MODULE_AUTHOR("Rogier Wolff <R.E.Wolff@bitwizard.nl>, Patrick van de Lageweg <patrick@bitwizard.nl>");
MODULE_DESCRIPTION("RIO driver");
Expand Down
4 changes: 2 additions & 2 deletions drivers/char/stallion.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ static int stl_parsebrd(stlconf_t *confp, char **argp);

static unsigned long stl_atol(char *str);

int stl_init(void);
static int stl_init(void);
static int stl_open(struct tty_struct *tty, struct file *filp);
static void stl_close(struct tty_struct *tty, struct file *filp);
static int stl_write(struct tty_struct *tty, const unsigned char *buf, int count);
Expand Down Expand Up @@ -3063,7 +3063,7 @@ static struct tty_operations stl_ops = {

/*****************************************************************************/

int __init stl_init(void)
static int __init stl_init(void)
{
int i;
printk(KERN_INFO "%s: version %s\n", stl_drvtitle, stl_drvversion);
Expand Down
10 changes: 5 additions & 5 deletions drivers/isdn/capi/capi.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ MODULE_LICENSE("GPL");

static struct class_simple *capi_class;

int capi_major = 68; /* allocated */
static int capi_major = 68; /* allocated */
#ifdef CONFIG_ISDN_CAPI_MIDDLEWARE
#define CAPINC_NR_PORTS 32
#define CAPINC_MAX_PORTS 256
int capi_ttymajor = 191;
int capi_ttyminors = CAPINC_NR_PORTS;
static int capi_ttymajor = 191;
static int capi_ttyminors = CAPINC_NR_PORTS;
#endif /* CONFIG_ISDN_CAPI_MIDDLEWARE */

module_param_named(major, capi_major, uint, 0);
Expand Down Expand Up @@ -268,7 +268,7 @@ static void capiminor_free(struct capiminor *mp)
kfree(mp);
}

struct capiminor *capiminor_find(unsigned int minor)
static struct capiminor *capiminor_find(unsigned int minor)
{
struct list_head *l;
struct capiminor *p = NULL;
Expand Down Expand Up @@ -1166,7 +1166,7 @@ static int capinc_tty_write_room(struct tty_struct *tty)
return room;
}

int capinc_tty_chars_in_buffer(struct tty_struct *tty)
static int capinc_tty_chars_in_buffer(struct tty_struct *tty)
{
struct capiminor *mp = (struct capiminor *)tty->driver_data;
if (!mp || !mp->nccip) {
Expand Down
10 changes: 5 additions & 5 deletions drivers/isdn/capi/kcapi_proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,14 @@ static int contrstats_show(struct seq_file *seq, void *v)
return 0;
}

struct seq_operations seq_controller_ops = {
static struct seq_operations seq_controller_ops = {
.start = controller_start,
.next = controller_next,
.stop = controller_stop,
.show = controller_show,
};

struct seq_operations seq_contrstats_ops = {
static struct seq_operations seq_contrstats_ops = {
.start = controller_start,
.next = controller_next,
.stop = controller_stop,
Expand Down Expand Up @@ -192,14 +192,14 @@ applstats_show(struct seq_file *seq, void *v)
return 0;
}

struct seq_operations seq_applications_ops = {
static struct seq_operations seq_applications_ops = {
.start = applications_start,
.next = applications_next,
.stop = applications_stop,
.show = applications_show,
};

struct seq_operations seq_applstats_ops = {
static struct seq_operations seq_applstats_ops = {
.start = applications_start,
.next = applications_next,
.stop = applications_stop,
Expand Down Expand Up @@ -287,7 +287,7 @@ static int capi_driver_show(struct seq_file *seq, void *v)
return 0;
}

struct seq_operations seq_capi_driver_ops = {
static struct seq_operations seq_capi_driver_ops = {
.start = capi_driver_start,
.next = capi_driver_next,
.stop = capi_driver_stop,
Expand Down
10 changes: 5 additions & 5 deletions drivers/isdn/divert/isdn_divert.c
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ divert_rule *getruleptr(int idx)
/*************************************************/
/* called from common module on an incoming call */
/*************************************************/
int isdn_divert_icall(isdn_ctrl *ic)
static int isdn_divert_icall(isdn_ctrl *ic)
{ int retval = 0;
unsigned long flags;
struct call_struc *cs = NULL;
Expand Down Expand Up @@ -552,7 +552,7 @@ void deleteprocs(void)
/****************************************************/
/* put a address including address type into buffer */
/****************************************************/
int put_address(char *st, u_char *p, int len)
static int put_address(char *st, u_char *p, int len)
{ u_char retval = 0;
u_char adr_typ = 0; /* network standard */

Expand Down Expand Up @@ -595,7 +595,7 @@ int put_address(char *st, u_char *p, int len)
/*************************************/
/* report a succesfull interrogation */
/*************************************/
int interrogate_success(isdn_ctrl *ic, struct call_struc *cs)
static int interrogate_success(isdn_ctrl *ic, struct call_struc *cs)
{ char *src = ic->parm.dss1_io.data;
int restlen = ic->parm.dss1_io.datalen;
int cnt = 1;
Expand Down Expand Up @@ -689,7 +689,7 @@ int interrogate_success(isdn_ctrl *ic, struct call_struc *cs)
/*********************************************/
/* callback for protocol specific extensions */
/*********************************************/
int prot_stat_callback(isdn_ctrl *ic)
static int prot_stat_callback(isdn_ctrl *ic)
{ struct call_struc *cs, *cs1;
int i;
unsigned long flags;
Expand Down Expand Up @@ -781,7 +781,7 @@ int prot_stat_callback(isdn_ctrl *ic)
/***************************/
/* status callback from HL */
/***************************/
int isdn_divert_stat_callback(isdn_ctrl *ic)
static int isdn_divert_stat_callback(isdn_ctrl *ic)
{ struct call_struc *cs, *cs1;
unsigned long flags;
int retval;
Expand Down
6 changes: 3 additions & 3 deletions drivers/media/video/bttv-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -3169,7 +3169,7 @@ static struct video_device radio_template =
/* ----------------------------------------------------------------------- */
/* some debug code */

int bttv_risc_decode(u32 risc)
static int bttv_risc_decode(u32 risc)
{
static char *instr[16] = {
[ BT848_RISC_WRITE >> 28 ] = "write",
Expand Down Expand Up @@ -3206,8 +3206,8 @@ int bttv_risc_decode(u32 risc)
return incr[risc >> 28] ? incr[risc >> 28] : 1;
}

void bttv_risc_disasm(struct bttv *btv,
struct btcx_riscmem *risc)
static void bttv_risc_disasm(struct bttv *btv,
struct btcx_riscmem *risc)
{
unsigned int i,j,n;

Expand Down
5 changes: 2 additions & 3 deletions drivers/media/video/cx88/cx88-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ int cx88_sram_channel_setup(struct cx88_core *core,
/* ------------------------------------------------------------------ */
/* debug helper code */

int cx88_risc_decode(u32 risc)
static int cx88_risc_decode(u32 risc)
{
static char *instr[16] = {
[ RISC_SYNC >> 28 ] = "sync",
Expand Down Expand Up @@ -542,7 +542,7 @@ void cx88_sram_channel_dump(struct cx88_core *core,
core->name,cx_read(ch->cnt2_reg));
}

char *cx88_pci_irqs[32] = {
static char *cx88_pci_irqs[32] = {
"vid", "aud", "ts", "vip", "hst", "5", "6", "tm1",
"src_dma", "dst_dma", "risc_rd_err", "risc_wr_err",
"brdg_err", "src_dma_err", "dst_dma_err", "ipb_dma_err",
Expand Down Expand Up @@ -1206,7 +1206,6 @@ void cx88_core_put(struct cx88_core *core, struct pci_dev *pci)
/* ------------------------------------------------------------------ */

EXPORT_SYMBOL(cx88_print_ioctl);
EXPORT_SYMBOL(cx88_pci_irqs);
EXPORT_SYMBOL(cx88_vid_irqs);
EXPORT_SYMBOL(cx88_mpeg_irqs);
EXPORT_SYMBOL(cx88_print_irqbits);
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/video/cx88/cx88-dvb.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ static void dvb_buf_release(struct videobuf_queue *q, struct videobuf_buffer *vb
cx88_free_buffer(dev->pci, (struct cx88_buffer*)vb);
}

struct videobuf_queue_ops dvb_qops = {
static struct videobuf_queue_ops dvb_qops = {
.buf_setup = dvb_buf_setup,
.buf_prepare = dvb_buf_prepare,
.buf_queue = dvb_buf_queue,
Expand Down Expand Up @@ -191,7 +191,7 @@ static int or51132_set_ts_param(struct dvb_frontend* fe,
return 0;
}

struct or51132_config pchdtv_hd3000 = {
static struct or51132_config pchdtv_hd3000 = {
.demod_address = 0x15,
.pll_address = 0x61,
.pll_desc = &dvb_pll_thomson_dtt7610,
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/video/cx88/cx88-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ MODULE_PARM_DESC(i2c_scan,"scan i2c bus at insmod time");

/* ----------------------------------------------------------------------- */

void cx8800_bit_setscl(void *data, int state)
static void cx8800_bit_setscl(void *data, int state)
{
struct cx88_core *core = data;

Expand All @@ -57,7 +57,7 @@ void cx8800_bit_setscl(void *data, int state)
cx_read(MO_I2C);
}

void cx8800_bit_setsda(void *data, int state)
static void cx8800_bit_setsda(void *data, int state)
{
struct cx88_core *core = data;

Expand Down
Loading

0 comments on commit 408b664

Please sign in to comment.