Skip to content

Commit

Permalink
dmaengine: imx-sdma: sdma_get_firmware does not need to copy fw_name
Browse files Browse the repository at this point in the history
It does not need to allocate space and copy fw_name in function
sdma_get_firmware().

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Vinod Koul <vinod.koul@intel.com>
  • Loading branch information
Shawn Guo committed Jul 27, 2011
1 parent 62550cd commit 40ad5b3
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/dma/imx-sdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -1126,22 +1126,14 @@ static int __init sdma_get_firmware(struct sdma_engine *sdma,
const char *fw_name)
{
const struct firmware *fw;
char *fwname;
const struct sdma_firmware_header *header;
int ret;
const struct sdma_script_start_addrs *addr;
unsigned short *ram_code;

fwname = kasprintf(GFP_KERNEL, "%s", fw_name);
if (!fwname)
return -ENOMEM;

ret = request_firmware(&fw, fwname, sdma->dev);
if (ret) {
kfree(fwname);
ret = request_firmware(&fw, fw_name, sdma->dev);
if (ret)
return ret;
}
kfree(fwname);

if (fw->size < sizeof(*header))
goto err_firmware;
Expand Down

0 comments on commit 40ad5b3

Please sign in to comment.