Skip to content

Commit

Permalink
Revert "Execute AML Notify() requests on stack."
Browse files Browse the repository at this point in the history
This reverts commit 5f7748c.

While that change fixed the HP
http://bugzilla.kernel.org/show_bug.cgi?id=5534

it broke the ACER:
http://bugzilla.kernel.org/show_bug.cgi?id=8385
which as AML that caused Linux go recursive
and stack fault.

So this commit by itself will restore the ACER
and again break the HP, which we'll fix another way.

Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Len Brown committed May 10, 2007
1 parent 4d2acd9 commit 40d0708
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions drivers/acpi/events/evmisc.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,12 @@ acpi_ev_queue_notify_request(struct acpi_namespace_node * node,
notify_info->notify.value = (u16) notify_value;
notify_info->notify.handler_obj = handler_obj;

acpi_ex_relinquish_interpreter();

acpi_ev_notify_dispatch(notify_info);

acpi_ex_reacquire_interpreter();
status =
acpi_os_execute(OSL_NOTIFY_HANDLER, acpi_ev_notify_dispatch,
notify_info);
if (ACPI_FAILURE(status)) {
acpi_ut_delete_generic_state(notify_info);
}
}

if (!handler_obj) {
Expand Down

0 comments on commit 40d0708

Please sign in to comment.