Skip to content

Commit

Permalink
[PATCH] readv/writev syscalls are not checked by lsm
Browse files Browse the repository at this point in the history
it seems that readv(2)/writev(2) syscalls do not call
file_permission callback. Looks like this is overlook.

I have filled the issue into redhat bugzilla as
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169433
and got the recommendation to post this on lsm mailing list.

The following trivial patch solves the problem.

Signed-off-by: Kostik Belousov <kostikbel@gmail.com>
Signed-off-by: Chris Wright <chrisw@osdl.org>
  • Loading branch information
Kostik Belousov authored and Chris Wright committed Sep 29, 2005
1 parent aa55a08 commit 411b67b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fs/read_write.c
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,9 @@ static ssize_t do_readv_writev(int type, struct file *file,
}

ret = rw_verify_area(type, file, pos, tot_len);
if (ret)
goto out;
ret = security_file_permission(file, type == READ ? MAY_READ : MAY_WRITE);
if (ret)
goto out;

Expand Down

0 comments on commit 411b67b

Please sign in to comment.