Skip to content

Commit

Permalink
igb: Do not overwrite mdicnfg register when accessing 82580 phy
Browse files Browse the repository at this point in the history
This change removes the extra configuration we were doing on the mdicnfg
register which should be set by EEPROM and which we should not need to
write again afterwards.  This code was a holdover from some earlier
development work that was being done on a board with an incomplete EEPROM
and is no longer needed now that the production EEPROMs are in place.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Duyck authored and David S. Miller committed Mar 23, 2010
1 parent 33e2bf6 commit 411f557
Showing 1 changed file with 0 additions and 20 deletions.
20 changes: 0 additions & 20 deletions drivers/net/igb/e1000_82575.c
Original file line number Diff line number Diff line change
Expand Up @@ -1446,23 +1446,13 @@ void igb_vmdq_set_replication_pf(struct e1000_hw *hw, bool enable)
**/
static s32 igb_read_phy_reg_82580(struct e1000_hw *hw, u32 offset, u16 *data)
{
u32 mdicnfg = 0;
s32 ret_val;


ret_val = hw->phy.ops.acquire(hw);
if (ret_val)
goto out;

/*
* We config the phy address in MDICNFG register now. Same bits
* as before. The values in MDIC can be written but will be
* ignored. This allows us to call the old function after
* configuring the PHY address in the new register
*/
mdicnfg = (hw->phy.addr << E1000_MDIC_PHY_SHIFT);
wr32(E1000_MDICNFG, mdicnfg);

ret_val = igb_read_phy_reg_mdic(hw, offset, data);

hw->phy.ops.release(hw);
Expand All @@ -1481,23 +1471,13 @@ static s32 igb_read_phy_reg_82580(struct e1000_hw *hw, u32 offset, u16 *data)
**/
static s32 igb_write_phy_reg_82580(struct e1000_hw *hw, u32 offset, u16 data)
{
u32 mdicnfg = 0;
s32 ret_val;


ret_val = hw->phy.ops.acquire(hw);
if (ret_val)
goto out;

/*
* We config the phy address in MDICNFG register now. Same bits
* as before. The values in MDIC can be written but will be
* ignored. This allows us to call the old function after
* configuring the PHY address in the new register
*/
mdicnfg = (hw->phy.addr << E1000_MDIC_PHY_SHIFT);
wr32(E1000_MDICNFG, mdicnfg);

ret_val = igb_write_phy_reg_mdic(hw, offset, data);

hw->phy.ops.release(hw);
Expand Down

0 comments on commit 411f557

Please sign in to comment.