Skip to content

Commit

Permalink
regulator: tps65218: Remove unnecessary regulator_unregister call
Browse files Browse the repository at this point in the history
Current code uses devm_regulator_register() so the we don't need to explicitly
call regulator_unregister() in .remove.
And then we don't need to save rdev pointer to tps->rdev[id].

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Axel Lin authored and Mark Brown committed Feb 19, 2014
1 parent c46b529 commit 413be59
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions drivers/regulator/tps65218-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,23 +267,6 @@ static int tps65218_regulator_probe(struct platform_device *pdev)
return PTR_ERR(rdev);
}

/* Save regulator */
tps->rdev[id] = rdev;

return 0;
}

static int tps65218_regulator_remove(struct platform_device *pdev)
{
struct tps65218 *tps = platform_get_drvdata(pdev);
const struct of_device_id *match;
const struct tps_info *template;

match = of_match_device(tps65218_of_match, &pdev->dev);
template = match->data;
regulator_unregister(tps->rdev[template->id]);
platform_set_drvdata(pdev, NULL);

return 0;
}

Expand All @@ -294,7 +277,6 @@ static struct platform_driver tps65218_regulator_driver = {
.of_match_table = of_match_ptr(tps65218_of_match),
},
.probe = tps65218_regulator_probe,
.remove = tps65218_regulator_remove,
};

module_platform_driver(tps65218_regulator_driver);
Expand Down

0 comments on commit 413be59

Please sign in to comment.