Skip to content

Commit

Permalink
Staging: crystalhd: crystalhd_misc: improved debug macros
Browse files Browse the repository at this point in the history
Improvement of debug macros to ensure safe use on if/else statements.

Signed-off-by: Jorgyano Vieira <jorgyano@gmail.com>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jorgyano Vieira authored and Greg Kroah-Hartman committed Feb 16, 2012
1 parent 2140dc9 commit 413db8c
Showing 1 changed file with 25 additions and 21 deletions.
46 changes: 25 additions & 21 deletions drivers/staging/crystalhd/crystalhd_misc.h
Original file line number Diff line number Diff line change
Expand Up @@ -203,26 +203,30 @@ enum _chd_log_levels {
BCMLOG_ENTER_LEAVE = 0x00000008, /* stack tracking */
};

#define BCMLOG_ENTER \
if (g_linklog_level & BCMLOG_ENTER_LEAVE) { \
printk(KERN_DEBUG "Entered %s\n", __func__); \
}

#define BCMLOG_LEAVE \
if (g_linklog_level & BCMLOG_ENTER_LEAVE) { \
printk(KERN_DEBUG "Leaving %s\n", __func__); \
}

#define BCMLOG(trace, fmt, args...) \
if (g_linklog_level & trace) { \
printk(fmt, ##args); \
}

#define BCMLOG_ERR(fmt, args...) \
do { \
if (g_linklog_level & BCMLOG_ERROR) { \
printk(KERN_ERR "*ERR*:%s:%d: "fmt, __FILE__, __LINE__, ##args); \
} \
} while (0);
#define BCMLOG_ENTER \
do { \
if (g_linklog_level & BCMLOG_ENTER_LEAVE) \
printk(KERN_DEBUG "Entered %s\n", __func__); \
} while (0)

#define BCMLOG_LEAVE \
do { \
if (g_linklog_level & BCMLOG_ENTER_LEAVE) \
printk(KERN_DEBUG "Leaving %s\n", __func__); \
} while (0) \

#define BCMLOG(trace, fmt, args...) \
do { \
if (g_linklog_level & trace) \
printk(fmt, ##args); \
} while (0)


#define BCMLOG_ERR(fmt, args...) \
do { \
if (g_linklog_level & BCMLOG_ERROR) \
printk(KERN_ERR "*ERR*:%s:%d: "fmt, \
__FILE__, __LINE__, ##args); \
} while (0)

#endif

0 comments on commit 413db8c

Please sign in to comment.