Skip to content

Commit

Permalink
V4L/DVB (13716): [Mantis] Bug: incorrect byte swap
Browse files Browse the repository at this point in the history
You know, the worst endianness errors are not the cases where
people forget to byte-swap, but the cases where they either byte-swap
with the wrong size, or byte-swap when they shouldn't have done so at
all. Those ones defeat the casual reader of the code.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
David Woodhouse authored and Mauro Carvalho Chehab committed Jan 17, 2010
1 parent 8154bad commit 4170368
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/dvb/mantis/mantis_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ void mantis_dma_start(struct mantis_pci *mantis)
dprintk(verbose, MANTIS_DEBUG, 1, "Mantis Start DMA engine");

mantis_risc_program(mantis);
mmwrite(cpu_to_le32(mantis->risc_dma), MANTIS_RISC_START);
mmwrite(mantis->risc_dma, MANTIS_RISC_START);
mmwrite(mmread(MANTIS_GPIF_ADDR) | MANTIS_GPIF_RDWRN, MANTIS_GPIF_ADDR);

mmwrite(0, MANTIS_DMA_CTL);
Expand Down

0 comments on commit 4170368

Please sign in to comment.