Skip to content

Commit

Permalink
sh_eth: do not reset PHY needlessly
Browse files Browse the repository at this point in the history
There's no need anymore to call phy_init_hw() to reset/resume the PHY from the
driver, as the call chain in phylib already has reached it, and so reset/resumed
the PHY (even resuming it twice). This duplicate reset is not only  needless, it
e.g. clears the PHY's interrupt enables just setup by phylib and so prevents the
expected IRQs from the PHY.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sergei Shtylyov authored and David S. Miller committed Dec 20, 2013
1 parent 18be099 commit 4174ecd
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/net/ethernet/renesas/sh_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -1703,11 +1703,6 @@ static int sh_eth_phy_start(struct net_device *ndev)
if (ret)
return ret;

/* reset phy - this also wakes it from PDOWN */
ret = phy_init_hw(mdp->phydev);
if (ret)
return ret;

phy_start(mdp->phydev);

return 0;
Expand Down

0 comments on commit 4174ecd

Please sign in to comment.