Skip to content

Commit

Permalink
V4L/DVB (4001): Cx88 NTSC VBI fixes
Browse files Browse the repository at this point in the history
VBI (Closed Caption, CC) capturing never worked in NTSC mode with the
cx88 driver.
They were tested with libzvbi and a patched version of tvtime.

Signed-off-by: Michael H. Schimek <mschimek@gmx.at>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Michael Schimek authored and Mauro Carvalho Chehab committed Jun 25, 2006
1 parent 7f2c8a9 commit 419ac5d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/media/video/cx88/cx88-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ static unsigned int inline norm_htotal(struct cx88_tvnorm *norm)

static unsigned int inline norm_vbipack(struct cx88_tvnorm *norm)
{
return (norm->id & V4L2_STD_625_50) ? 511 : 288;
return (norm->id & V4L2_STD_625_50) ? 511 : 400;
}

int cx88_set_scale(struct cx88_core *core, unsigned int width, unsigned int height,
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/video/cx88/cx88-vbi.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ void cx8800_vbi_fmt(struct cx8800_dev *dev, struct v4l2_format *f)
if (dev->core->tvnorm->id & V4L2_STD_525_60) {
/* ntsc */
f->fmt.vbi.sampling_rate = 28636363;
f->fmt.vbi.start[0] = 10 -1;
f->fmt.vbi.start[1] = 273 -1;
f->fmt.vbi.start[0] = 10;
f->fmt.vbi.start[1] = 273;

} else if (dev->core->tvnorm->id & V4L2_STD_625_50) {
/* pal */
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/cx88/cx88.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

#include <linux/version.h>
#include <linux/mutex.h>
#define CX88_VERSION_CODE KERNEL_VERSION(0,0,5)
#define CX88_VERSION_CODE KERNEL_VERSION(0,0,6)

#ifndef TRUE
# define TRUE (1==1)
Expand Down

0 comments on commit 419ac5d

Please sign in to comment.