Skip to content

Commit

Permalink
[XFS] xfs_unmountfs should return void
Browse files Browse the repository at this point in the history
xfs_unmounts can't and shouldn't return errors so declare it as returning
void.

SGI-PV: 981498

SGI-Modid: xfs-linux-melb:xfs-kern:31833a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
  • Loading branch information
Christoph Hellwig authored and Lachlan McIlroy committed Aug 13, 2008
1 parent 4249023 commit 41b5c2e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
12 changes: 5 additions & 7 deletions fs/xfs/xfs_mount.c
Original file line number Diff line number Diff line change
Expand Up @@ -1229,16 +1229,15 @@ xfs_mountfs(
}

/*
* xfs_unmountfs
*
* This flushes out the inodes,dquots and the superblock, unmounts the
* log and makes sure that incore structures are freed.
*/
int
xfs_unmountfs(xfs_mount_t *mp)
void
xfs_unmountfs(
struct xfs_mount *mp)
{
__uint64_t resblks;
int error = 0;
__uint64_t resblks;
int error;

IRELE(mp->m_rootip);

Expand Down Expand Up @@ -1311,7 +1310,6 @@ xfs_unmountfs(xfs_mount_t *mp)
xfs_errortag_clearall(mp, 0);
#endif
xfs_mount_free(mp);
return 0;
}

STATIC void
Expand Down
2 changes: 1 addition & 1 deletion fs/xfs/xfs_mount.h
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ extern int xfs_log_sbcount(xfs_mount_t *, uint);
extern int xfs_mountfs(xfs_mount_t *mp);
extern void xfs_mountfs_check_barriers(xfs_mount_t *mp);

extern int xfs_unmountfs(xfs_mount_t *);
extern void xfs_unmountfs(xfs_mount_t *);
extern int xfs_unmountfs_writesb(xfs_mount_t *);
extern int xfs_unmount_flush(xfs_mount_t *, int);
extern int xfs_mod_incore_sb(xfs_mount_t *, xfs_sb_field_t, int64_t, int);
Expand Down

0 comments on commit 41b5c2e

Please sign in to comment.