Skip to content

Commit

Permalink
drm/i915: Kill dev_priv->irq_received
Browse files Browse the repository at this point in the history
Not sure anyone cares about this information. I suppose most people
would just look at /proc/interrupts instead.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Ville Syrjälä authored and Daniel Vetter committed Jan 24, 2014
1 parent 501e01d commit 41c54e5
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 30 deletions.
2 changes: 0 additions & 2 deletions drivers/gpu/drm/i915/i915_debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -712,8 +712,6 @@ static int i915_interrupt_info(struct seq_file *m, void *data)
seq_printf(m, "Graphics Interrupt mask: %08x\n",
I915_READ(GTIMR));
}
seq_printf(m, "Interrupts received: %d\n",
atomic_read(&dev_priv->irq_received));
for_each_ring(ring, dev_priv, i) {
if (INTEL_INFO(dev)->gen >= 6) {
seq_printf(m,
Expand Down
2 changes: 0 additions & 2 deletions drivers/gpu/drm/i915/i915_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -1360,8 +1360,6 @@ typedef struct drm_i915_private {
drm_dma_handle_t *status_page_dmah;
struct resource mch_res;

atomic_t irq_received;

/* protects the irq masks */
spinlock_t irq_lock;

Expand Down
26 changes: 0 additions & 26 deletions drivers/gpu/drm/i915/i915_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -1434,8 +1434,6 @@ static irqreturn_t valleyview_irq_handler(int irq, void *arg)
int pipe;
u32 pipe_stats[I915_MAX_PIPES];

atomic_inc(&dev_priv->irq_received);

while (true) {
iir = I915_READ(VLV_IIR);
gt_iir = I915_READ(GTIIR);
Expand Down Expand Up @@ -1744,8 +1742,6 @@ static irqreturn_t ironlake_irq_handler(int irq, void *arg)
u32 de_iir, gt_iir, de_ier, sde_ier = 0;
irqreturn_t ret = IRQ_NONE;

atomic_inc(&dev_priv->irq_received);

/* We get interrupts on unclaimed registers, so check for this before we
* do any I915_{READ,WRITE}. */
intel_uncore_check_errors(dev);
Expand Down Expand Up @@ -1814,8 +1810,6 @@ static irqreturn_t gen8_irq_handler(int irq, void *arg)
uint32_t tmp = 0;
enum pipe pipe;

atomic_inc(&dev_priv->irq_received);

master_ctl = I915_READ(GEN8_MASTER_IRQ);
master_ctl &= ~GEN8_MASTER_IRQ_CONTROL;
if (!master_ctl)
Expand Down Expand Up @@ -2638,8 +2632,6 @@ static void ironlake_irq_preinstall(struct drm_device *dev)
{
drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;

atomic_set(&dev_priv->irq_received, 0);

I915_WRITE(HWSTAM, 0xeffe);

I915_WRITE(DEIMR, 0xffffffff);
Expand All @@ -2656,8 +2648,6 @@ static void valleyview_irq_preinstall(struct drm_device *dev)
drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
int pipe;

atomic_set(&dev_priv->irq_received, 0);

/* VLV magic */
I915_WRITE(VLV_IMR, 0);
I915_WRITE(RING_IMR(RENDER_RING_BASE), 0);
Expand Down Expand Up @@ -2687,8 +2677,6 @@ static void gen8_irq_preinstall(struct drm_device *dev)
struct drm_i915_private *dev_priv = dev->dev_private;
int pipe;

atomic_set(&dev_priv->irq_received, 0);

I915_WRITE(GEN8_MASTER_IRQ, 0);
POSTING_READ(GEN8_MASTER_IRQ);

Expand Down Expand Up @@ -3013,8 +3001,6 @@ static void gen8_irq_uninstall(struct drm_device *dev)
if (!dev_priv)
return;

atomic_set(&dev_priv->irq_received, 0);

I915_WRITE(GEN8_MASTER_IRQ, 0);

#define GEN8_IRQ_FINI_NDX(type, which) do { \
Expand Down Expand Up @@ -3107,8 +3093,6 @@ static void i8xx_irq_preinstall(struct drm_device * dev)
drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
int pipe;

atomic_set(&dev_priv->irq_received, 0);

for_each_pipe(pipe)
I915_WRITE(PIPESTAT(pipe), 0);
I915_WRITE16(IMR, 0xffff);
Expand Down Expand Up @@ -3193,8 +3177,6 @@ static irqreturn_t i8xx_irq_handler(int irq, void *arg)
I915_DISPLAY_PLANE_A_FLIP_PENDING_INTERRUPT |
I915_DISPLAY_PLANE_B_FLIP_PENDING_INTERRUPT;

atomic_inc(&dev_priv->irq_received);

iir = I915_READ16(IIR);
if (iir == 0)
return IRQ_NONE;
Expand Down Expand Up @@ -3272,8 +3254,6 @@ static void i915_irq_preinstall(struct drm_device * dev)
drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
int pipe;

atomic_set(&dev_priv->irq_received, 0);

if (I915_HAS_HOTPLUG(dev)) {
I915_WRITE(PORT_HOTPLUG_EN, 0);
I915_WRITE(PORT_HOTPLUG_STAT, I915_READ(PORT_HOTPLUG_STAT));
Expand Down Expand Up @@ -3379,8 +3359,6 @@ static irqreturn_t i915_irq_handler(int irq, void *arg)
I915_DISPLAY_PLANE_B_FLIP_PENDING_INTERRUPT;
int pipe, ret = IRQ_NONE;

atomic_inc(&dev_priv->irq_received);

iir = I915_READ(IIR);
do {
bool irq_received = (iir & ~flip_mask) != 0;
Expand Down Expand Up @@ -3503,8 +3481,6 @@ static void i965_irq_preinstall(struct drm_device * dev)
drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
int pipe;

atomic_set(&dev_priv->irq_received, 0);

I915_WRITE(PORT_HOTPLUG_EN, 0);
I915_WRITE(PORT_HOTPLUG_STAT, I915_READ(PORT_HOTPLUG_STAT));

Expand Down Expand Up @@ -3618,8 +3594,6 @@ static irqreturn_t i965_irq_handler(int irq, void *arg)
I915_DISPLAY_PLANE_A_FLIP_PENDING_INTERRUPT |
I915_DISPLAY_PLANE_B_FLIP_PENDING_INTERRUPT;

atomic_inc(&dev_priv->irq_received);

iir = I915_READ(IIR);

for (;;) {
Expand Down

0 comments on commit 41c54e5

Please sign in to comment.