Skip to content

Commit

Permalink
x86/amd-iommu: Use check_device for amd_iommu_dma_supported
Browse files Browse the repository at this point in the history
The check_device logic needs to include the dma_supported
checks to be really sure. Merge the dma_supported logic into
check_device and use it to implement dma_supported.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
  • Loading branch information
Joerg Roedel committed Nov 27, 2009
1 parent 318afd4 commit 420aef8
Showing 1 changed file with 19 additions and 16 deletions.
35 changes: 19 additions & 16 deletions arch/x86/kernel/amd_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1375,9 +1375,27 @@ static struct notifier_block device_nb = {
*/
static bool check_device(struct device *dev)
{
u16 bdf;
struct pci_dev *pcidev;

if (!dev || !dev->dma_mask)
return false;

/* No device or no PCI device */
if (!dev || dev->bus != &pci_bus_type)
return false;

pcidev = to_pci_dev(dev);

bdf = calc_devid(pcidev->bus->number, pcidev->devfn);

/* Out of our scope? */
if (bdf > amd_iommu_last_bdf)
return false;

if (amd_iommu_rlookup_table[bdf] == NULL)
return false;

return true;
}

Expand Down Expand Up @@ -2065,22 +2083,7 @@ static void free_coherent(struct device *dev, size_t size,
*/
static int amd_iommu_dma_supported(struct device *dev, u64 mask)
{
u16 bdf;
struct pci_dev *pcidev;

/* No device or no PCI device */
if (!dev || dev->bus != &pci_bus_type)
return 0;

pcidev = to_pci_dev(dev);

bdf = calc_devid(pcidev->bus->number, pcidev->devfn);

/* Out of our scope? */
if (bdf > amd_iommu_last_bdf)
return 0;

return 1;
return check_device(dev);
}

/*
Expand Down

0 comments on commit 420aef8

Please sign in to comment.