Skip to content

Commit

Permalink
bd_claim_by_disk: fix warning
Browse files Browse the repository at this point in the history
Fix this:

fs/block_dev.c: In function 'bd_claim_by_disk':
fs/block_dev.c:970: warning: 'found' may be used uninitialized in this function

and given that free_bd_holder() now needs free(NULL)-is-legal behaviour, we
can simplify bd_release_from_kobject().

Cc: Bjorn Steinbrink <B.Steinbrink@gmx.de>
Cc: Johannes Weiner <hannes-kernel@saeurebad.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andrew Morton authored and Linus Torvalds committed Jul 16, 2007
1 parent 4e91672 commit 4210df2
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions fs/block_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -963,20 +963,20 @@ static int bd_claim_by_kobject(struct block_device *bdev, void *holder,

err = bd_claim(bdev, holder);
if (err)
goto out;
goto fail;

found = find_bd_holder(bdev, bo);
if (found)
goto out;
goto fail;

err = add_bd_holder(bdev, bo);
if (err)
bd_release(bdev);

out:
if (err || found)
free_bd_holder(bo);
else
bo = NULL;
fail:
mutex_unlock(&bdev->bd_mutex);
free_bd_holder(bo);
return err;
}

Expand All @@ -991,15 +991,12 @@ static int bd_claim_by_kobject(struct block_device *bdev, void *holder,
static void bd_release_from_kobject(struct block_device *bdev,
struct kobject *kobj)
{
struct bd_holder *bo;

if (!kobj)
return;

mutex_lock(&bdev->bd_mutex);
bd_release(bdev);
if ((bo = del_bd_holder(bdev, kobj)))
free_bd_holder(bo);
free_bd_holder(del_bd_holder(bdev, kobj));
mutex_unlock(&bdev->bd_mutex);
}

Expand Down

0 comments on commit 4210df2

Please sign in to comment.