Skip to content

Commit

Permalink
usb: host: ehci-tegra: fix PHY error handling
Browse files Browse the repository at this point in the history
PHY layer no longer returns NULL, we must
switch from IS_ERR_OR_NULL() to IS_ERR().

Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Felipe Balbi committed Mar 21, 2013
1 parent 249751f commit 4261b8f
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions drivers/usb/host/ehci-tegra.c
Original file line number Diff line number Diff line change
Expand Up @@ -768,14 +768,12 @@ static int tegra_ehci_probe(struct platform_device *pdev)
goto fail;
}

#if IS_ENABLED(CONFIG_USB_PHY)
if (pdata->operating_mode == TEGRA_USB_OTG) {
tegra->transceiver =
devm_usb_get_phy(&pdev->dev, USB_PHY_TYPE_USB2);
if (!IS_ERR_OR_NULL(tegra->transceiver))
if (!IS_ERR(tegra->transceiver))
otg_set_host(tegra->transceiver->otg, &hcd->self);
}
#endif

err = usb_add_hcd(hcd, irq, IRQF_SHARED);
if (err) {
Expand All @@ -794,10 +792,8 @@ static int tegra_ehci_probe(struct platform_device *pdev)
return err;

fail:
#if IS_ENABLED(CONFIG_USB_PHY)
if (!IS_ERR_OR_NULL(tegra->transceiver))
if (!IS_ERR(tegra->transceiver))
otg_set_host(tegra->transceiver->otg, NULL);
#endif
usb_phy_shutdown(hcd->phy);
fail_io:
clk_disable_unprepare(tegra->clk);
Expand All @@ -815,10 +811,8 @@ static int tegra_ehci_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);
pm_runtime_put_noidle(&pdev->dev);

#if IS_ENABLED(CONFIG_USB_PHY)
if (!IS_ERR_OR_NULL(tegra->transceiver))
if (!IS_ERR(tegra->transceiver))
otg_set_host(tegra->transceiver->otg, NULL);
#endif

usb_phy_shutdown(hcd->phy);
usb_remove_hcd(hcd);
Expand Down

0 comments on commit 4261b8f

Please sign in to comment.