Skip to content

Commit

Permalink
V4L/DVB (3639): Reduce FWSEND due to certain I2C bus adapter limits
Browse files Browse the repository at this point in the history
The FWSEND parameter controls the size of the firmware chunks sent
down the I2C bus to the chip.  Previously this had been set to 1024
but unfortunately some I2C implementations can't transfer data in such
big gulps.  Specifically, the pvrusb2 driver has a hard limit of
around 60 bytes, due to the encapsulation there of I2C traffic into
USB messages.  So we have to significantly reduce this parameter.
Acked-by: Hans Verkuil <hverkuil@xs4all.nl>

Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Mike Isely authored and Mauro Carvalho Chehab committed Apr 2, 2006
1 parent dbcb86e commit 4263fa8
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion drivers/media/video/cx25840/cx25840-firmware.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,17 @@
#include "cx25840-core.h"

#define FWFILE "v4l-cx25840.fw"
#define FWSEND 1024

/*
* Mike Isely <isely@pobox.com> - The FWSEND parameter controls the
* size of the firmware chunks sent down the I2C bus to the chip.
* Previously this had been set to 1024 but unfortunately some I2C
* implementations can't transfer data in such big gulps.
* Specifically, the pvrusb2 driver has a hard limit of around 60
* bytes, due to the encapsulation there of I2C traffic into USB
* messages. So we have to significantly reduce this parameter.
*/
#define FWSEND 48

#define FWDEV(x) &((x)->adapter->dev)

Expand Down

0 comments on commit 4263fa8

Please sign in to comment.