Skip to content

Commit

Permalink
iwlwifi: fix "MAC in deep sleep" error
Browse files Browse the repository at this point in the history
This patch fixes the misue of CSR_GP_CNTRL with CSR_RESET address
in polling the CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY bit in
iwl4965_apm_reset(). This causes "MAC in deep sleep" error sometimes.
The patch also fixes the timeout value and the iwl_poll_bit() return
value check.

Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Zhu, Yi authored and John W. Linville committed Dec 12, 2008
1 parent f056658 commit 42802d7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/wireless/iwlwifi/iwl-4965.c
Original file line number Diff line number Diff line change
Expand Up @@ -482,11 +482,11 @@ static int iwl4965_apm_reset(struct iwl_priv *priv)

iwl_set_bit(priv, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_INIT_DONE);

ret = iwl_poll_bit(priv, CSR_RESET,
ret = iwl_poll_bit(priv, CSR_GP_CNTRL,
CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY,
CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY, 25);
CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY, 25000);

if (ret)
if (ret < 0)
goto out;

udelay(10);
Expand Down

0 comments on commit 42802d7

Please sign in to comment.