Skip to content

Commit

Permalink
ath9k: do not call ath9k_hw_txprocdesc on AR9003 outside of the tx ta…
Browse files Browse the repository at this point in the history
…sklet

Since AR9003 uses a global tx status queue, processing tx status outside of
the regular tx tasklet is dangerous and messes up hardware/software
synchronization of tx status events.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Felix Fietkau authored and John W. Linville committed Mar 5, 2012
1 parent d6157bf commit 4286df6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/wireless/ath/ath9k/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2300,6 +2300,7 @@ static int ath9k_tx_last_beacon(struct ieee80211_hw *hw)
struct ath_vif *avp;
struct ath_buf *bf;
struct ath_tx_status ts;
bool edma = !!(ah->caps.hw_caps & ATH9K_HW_CAP_EDMA);
int status;

vif = sc->beacon.bslot[0];
Expand All @@ -2310,7 +2311,7 @@ static int ath9k_tx_last_beacon(struct ieee80211_hw *hw)
if (!avp->is_bslot_active)
return 0;

if (!sc->beacon.tx_processed) {
if (!sc->beacon.tx_processed && !edma) {
tasklet_disable(&sc->bcon_tasklet);

bf = avp->av_bcbuf;
Expand Down

0 comments on commit 4286df6

Please sign in to comment.