Skip to content

Commit

Permalink
cpuidle: move driver's refcount to cpuidle
Browse files Browse the repository at this point in the history
We want to support different cpuidle drivers co-existing together.
In this case we should move the refcount to the cpuidle_driver
structure to handle several drivers at a time.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Daniel Lezcano authored and Rafael J. Wysocki committed Nov 14, 2012
1 parent 8f3e995 commit 42f67f2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
13 changes: 8 additions & 5 deletions drivers/cpuidle/driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

static struct cpuidle_driver *cpuidle_curr_driver;
DEFINE_SPINLOCK(cpuidle_driver_lock);
int cpuidle_driver_refcount;

static void set_power_states(struct cpuidle_driver *drv)
{
Expand Down Expand Up @@ -61,6 +60,8 @@ int cpuidle_register_driver(struct cpuidle_driver *drv)
if (!drv->power_specified)
set_power_states(drv);

drv->refcnt = 0;

cpuidle_curr_driver = drv;

spin_unlock(&cpuidle_driver_lock);
Expand Down Expand Up @@ -92,7 +93,7 @@ void cpuidle_unregister_driver(struct cpuidle_driver *drv)

spin_lock(&cpuidle_driver_lock);

if (!WARN_ON(cpuidle_driver_refcount > 0))
if (!WARN_ON(drv->refcnt > 0))
cpuidle_curr_driver = NULL;

spin_unlock(&cpuidle_driver_lock);
Expand All @@ -106,18 +107,20 @@ struct cpuidle_driver *cpuidle_driver_ref(void)
spin_lock(&cpuidle_driver_lock);

drv = cpuidle_curr_driver;
cpuidle_driver_refcount++;
drv->refcnt++;

spin_unlock(&cpuidle_driver_lock);
return drv;
}

void cpuidle_driver_unref(void)
{
struct cpuidle_driver *drv = cpuidle_curr_driver;

spin_lock(&cpuidle_driver_lock);

if (!WARN_ON(cpuidle_driver_refcount <= 0))
cpuidle_driver_refcount--;
if (drv && !WARN_ON(drv->refcnt <= 0))
drv->refcnt--;

spin_unlock(&cpuidle_driver_lock);
}
1 change: 1 addition & 0 deletions include/linux/cpuidle.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ static inline int cpuidle_get_last_residency(struct cpuidle_device *dev)
struct cpuidle_driver {
const char *name;
struct module *owner;
int refcnt;

unsigned int power_specified:1;
/* set to 1 to use the core cpuidle time keeping (for all states). */
Expand Down

0 comments on commit 42f67f2

Please sign in to comment.