Skip to content

Commit

Permalink
usb: dwc3: gadget: don't force 'LST' always
Browse files Browse the repository at this point in the history
the LST bit is to be set on the last of a series
of consecutive TRBs. We had a workaround for a
problem where data would get corrupted but that
doesn't happen anymore. It's likely that it was
caused by some FPGA instability during development
phase.

Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Felipe Balbi committed Dec 21, 2011
1 parent 68e823e commit 42f8eb7
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions drivers/usb/dwc3/gadget.c
Original file line number Diff line number Diff line change
Expand Up @@ -672,16 +672,10 @@ static void dwc3_prepare_trbs(struct dwc3_ep *dep, bool starting)
if (list_empty(&dep->request_list))
last_one = 1;

/*
* FIXME we shouldn't need to set LST bit always but we are
* facing some weird problem with the Hardware where it doesn't
* complete even though it has been previously started.
*
* While we're debugging the problem, as a workaround to
* multiple TRBs handling, use only one TRB at a time.
*/
dwc3_prepare_one_trb(dep, req, true);
break;
dwc3_prepare_one_trb(dep, req, last_one);

if (last_one)
break;
}
}

Expand Down

0 comments on commit 42f8eb7

Please sign in to comment.