Skip to content

Commit

Permalink
xen: make use of pte_t union
Browse files Browse the repository at this point in the history
pte_t always contains a "pte" field for the whole pte value, so make
use of it.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Jeremy Fitzhardinge authored and Ingo Molnar committed Apr 24, 2008
1 parent abf3303 commit 430442e
Showing 1 changed file with 11 additions and 13 deletions.
24 changes: 11 additions & 13 deletions arch/x86/xen/mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,29 +216,27 @@ void xen_pmd_clear(pmd_t *pmdp)

pteval_t xen_pte_val(pte_t pte)
{
pteval_t ret = 0;
pteval_t ret = pte.pte;

if (pte.pte_low) {
ret = ((pteval_t)pte.pte_high << 32) | pte.pte_low;
ret = machine_to_phys(XMADDR(ret)).paddr | 1;
}
if (ret & _PAGE_PRESENT)
ret = machine_to_phys(XMADDR(ret)).paddr | _PAGE_PRESENT;

return ret;
}

pmdval_t xen_pmd_val(pmd_t pmd)
{
pmdval_t ret = pmd.pmd;
if (ret)
ret = machine_to_phys(XMADDR(ret)).paddr | 1;
if (ret & _PAGE_PRESENT)
ret = machine_to_phys(XMADDR(ret)).paddr | _PAGE_PRESENT;
return ret;
}

pgdval_t xen_pgd_val(pgd_t pgd)
{
pgdval_t ret = pgd.pgd;
if (ret)
ret = machine_to_phys(XMADDR(ret)).paddr | 1;
if (ret & _PAGE_PRESENT)
ret = machine_to_phys(XMADDR(ret)).paddr | _PAGE_PRESENT;
return ret;
}

Expand All @@ -254,7 +252,7 @@ pte_t xen_make_pte(pteval_t pte)

pmd_t xen_make_pmd(pmdval_t pmd)
{
if (pmd & 1)
if (pmd & _PAGE_PRESENT)
pmd = phys_to_machine(XPADDR(pmd)).maddr;

return (pmd_t){ pmd };
Expand All @@ -275,7 +273,7 @@ void xen_set_pte(pte_t *ptep, pte_t pte)

pteval_t xen_pte_val(pte_t pte)
{
pteval_t ret = pte.pte_low;
pteval_t ret = pte.pte;

if (ret & _PAGE_PRESENT)
ret = machine_to_phys(XMADDR(ret)).paddr;
Expand All @@ -286,8 +284,8 @@ pteval_t xen_pte_val(pte_t pte)
pgdval_t xen_pgd_val(pgd_t pgd)
{
pteval_t ret = pgd.pgd;
if (ret)
ret = machine_to_phys(XMADDR(ret)).paddr | 1;
if (ret & _PAGE_PRESENT)
ret = machine_to_phys(XMADDR(ret)).paddr | _PAGE_PRESENT;
return ret;
}

Expand Down

0 comments on commit 430442e

Please sign in to comment.