Skip to content

Commit

Permalink
solos: Slight debugging improvements
Browse files Browse the repository at this point in the history
Print a message if pskb_expand_head fails.

Make atmdebug writable by root, so that you can turn printing of data sent to
and received from the card on and off at runtime - useful for tracking
corruption.

Signed-off-by: Simon Farnsworth <simon@farnz.org.uk>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
Simon Farnsworth authored and David Woodhouse committed Jan 27, 2009
1 parent b76811a commit 4306cad
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/atm/solos-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ MODULE_LICENSE("GPL");
MODULE_PARM_DESC(debug, "Enable Loopback");
MODULE_PARM_DESC(atmdebug, "Print ATM data");
module_param(debug, int, 0444);
module_param(atmdebug, int, 0444);
module_param(atmdebug, int, 0644);

static int opens;

Expand Down Expand Up @@ -541,6 +541,7 @@ static int psend(struct atm_vcc *vcc, struct sk_buff *skb)

ret = pskb_expand_head(skb, expand_by, 0, GFP_ATOMIC);
if (ret) {
dev_warn(&card->dev->dev, "pskb_expand_head failed.\n");
solos_pop(vcc, skb);
return ret;
}
Expand Down

0 comments on commit 4306cad

Please sign in to comment.