Skip to content

Commit

Permalink
nohz: Remove update_ts_time_stat from tick_nohz_start_idle
Browse files Browse the repository at this point in the history
There is no reason to call update_ts_time_stat from tick_nohz_start_idle
anymore (after e0e37c2 sched: Eliminate the ts->idle_lastupdate field)
when we updated idle_lastupdate unconditionally.

We haven't set idle_active yet and do not provide last_update_time so
the whole call end up being just 2 wasted branches.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Link: http://lkml.kernel.org/r/1322755222-6951-1-git-send-email-mhocko@suse.cz
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Michal Hocko authored and Thomas Gleixner committed Feb 15, 2012
1 parent 77b0d60 commit 430ee88
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions kernel/time/tick-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,7 @@ static void tick_nohz_stop_idle(int cpu, ktime_t now)

static ktime_t tick_nohz_start_idle(int cpu, struct tick_sched *ts)
{
ktime_t now;

now = ktime_get();

update_ts_time_stats(cpu, ts, now, NULL);
ktime_t now = ktime_get();

ts->idle_entrytime = now;
ts->idle_active = 1;
Expand Down

0 comments on commit 430ee88

Please sign in to comment.