Skip to content

Commit

Permalink
[PATCH] i386: use safe_apic_wait_icr_idle in smpboot.c
Browse files Browse the repository at this point in the history
__inquire_remote_apic is used for APIC debugging, so use
safe_apic_wait_icr_idle  instead of apic_wait_icr_idle to avoid possible
lockups when APIC delivery fails.

Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
Signed-off-by: Andi Kleen <ak@suse.de>
  • Loading branch information
Fernando Luis VazquezCao authored and Andi Kleen committed May 2, 2007
1 parent ea8c733 commit 4312fa8
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions arch/i386/kernel/smpboot.c
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,8 @@ static inline void __inquire_remote_apic(int apicid)
{
int i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 };
char *names[] = { "ID", "VERSION", "SPIV" };
int timeout, status;
int timeout;
unsigned long status;

printk("Inquiring remote APIC #%d...\n", apicid);

Expand All @@ -531,7 +532,9 @@ static inline void __inquire_remote_apic(int apicid)
/*
* Wait for idle.
*/
apic_wait_icr_idle();
status = safe_apic_wait_icr_idle();
if (status)
printk("a previous APIC delivery may have failed\n");

apic_write_around(APIC_ICR2, SET_APIC_DEST_FIELD(apicid));
apic_write_around(APIC_ICR, APIC_DM_REMRD | regs[i]);
Expand Down

0 comments on commit 4312fa8

Please sign in to comment.