Skip to content

Commit

Permalink
[PATCH] libata-dev: irq-pio minor fix
Browse files Browse the repository at this point in the history
irq-pio minor fix:
- remove the redundant hsm_task_state = HSM_ST_IDLE
- add devno to printk() as done in upstream

Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Albert Lee authored and Jeff Garzik committed Apr 4, 2006
1 parent 862cff6 commit 4332a77
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
8 changes: 4 additions & 4 deletions drivers/scsi/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -4043,8 +4043,8 @@ static int ata_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc,
}

/* no more data to transfer */
DPRINTK("ata%u: command complete, drv_stat 0x%x\n",
ap->id, status);
DPRINTK("ata%u: dev %u command complete, drv_stat 0x%x\n",
ap->id, qc->dev->devno, status);

WARN_ON(qc->err_mask);

Expand All @@ -4061,8 +4061,8 @@ static int ata_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc,

case HSM_ST_ERR:
if (qc->tf.command != ATA_CMD_PACKET)
printk(KERN_ERR "ata%u: command error, drv_stat 0x%x\n",
ap->id, status);
printk(KERN_ERR "ata%u: dev %u command error, drv_stat 0x%x\n",
ap->id, qc->dev->devno, status);

/* make sure qc->err_mask is available to
* know what's wrong and recover
Expand Down
3 changes: 0 additions & 3 deletions drivers/scsi/libata-eh.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ int ata_scsi_error(struct Scsi_Host *host)
* LOCKING:
* Inherited from SCSI layer (none, can sleep)
*/

static void ata_qc_timeout(struct ata_queued_cmd *qc)
{
struct ata_port *ap = qc->ap;
Expand Down Expand Up @@ -172,8 +171,6 @@ static void ata_qc_timeout(struct ata_queued_cmd *qc)
printk(KERN_ERR "ata%u: command 0x%x timeout, stat 0x%x host_stat 0x%x\n",
ap->id, qc->tf.command, drv_stat, host_stat);

ap->hsm_task_state = HSM_ST_IDLE;

/* complete taskfile transaction */
qc->err_mask |= AC_ERR_TIMEOUT;
break;
Expand Down

0 comments on commit 4332a77

Please sign in to comment.