Skip to content

Commit

Permalink
pch_can: Replace netdev_dbg instead of dev_dbg partly
Browse files Browse the repository at this point in the history
For easy to readable, use netdev_dbg instead of dev_dbg partly

Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tomoya authored and David S. Miller committed Dec 13, 2010
1 parent e91530e commit 435b4ef
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/net/can/pch_can.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ static void pch_can_set_run_mode(struct pch_can_priv *priv,
break;

default:
dev_err(&priv->ndev->dev, "%s -> Invalid Mode.\n", __func__);
netdev_err(priv->ndev, "%s -> Invalid Mode.\n", __func__);
break;
}
}
Expand Down Expand Up @@ -275,7 +275,7 @@ static void pch_can_set_int_enables(struct pch_can_priv *priv,
break;

default:
dev_err(&priv->ndev->dev, "Invalid interrupt number.\n");
netdev_err(priv->ndev, "Invalid interrupt number.\n");
break;
}
}
Expand Down Expand Up @@ -528,7 +528,7 @@ static void pch_can_error(struct net_device *ndev, u32 status)
cf->data[1] |= CAN_ERR_CRTL_RX_WARNING;
if ((errc & PCH_TEC) > 96)
cf->data[1] |= CAN_ERR_CRTL_TX_WARNING;
dev_warn(&ndev->dev,
netdev_dbg(ndev,
"%s -> Error Counter is more than 96.\n", __func__);
}
/* Error passive interrupt. */
Expand All @@ -540,7 +540,7 @@ static void pch_can_error(struct net_device *ndev, u32 status)
cf->data[1] |= CAN_ERR_CRTL_RX_PASSIVE;
if ((errc & PCH_TEC) > 127)
cf->data[1] |= CAN_ERR_CRTL_TX_PASSIVE;
dev_err(&ndev->dev,
netdev_dbg(ndev,
"%s -> CAN controller is ERROR PASSIVE .\n", __func__);
}

Expand Down Expand Up @@ -859,25 +859,25 @@ static int pch_can_open(struct net_device *ndev)

retval = pci_enable_msi(priv->dev);
if (retval) {
dev_info(&ndev->dev, "PCH CAN opened without MSI\n");
netdev_err(ndev, "PCH CAN opened without MSI\n");
priv->use_msi = 0;
} else {
dev_info(&ndev->dev, "PCH CAN opened with MSI\n");
netdev_err(ndev, "PCH CAN opened with MSI\n");
priv->use_msi = 1;
}

/* Regsitering the interrupt. */
retval = request_irq(priv->dev->irq, pch_can_interrupt, IRQF_SHARED,
ndev->name, ndev);
if (retval) {
dev_err(&ndev->dev, "request_irq failed.\n");
netdev_err(ndev, "request_irq failed.\n");
goto req_irq_err;
}

/* Open common can device */
retval = open_candev(ndev);
if (retval) {
dev_err(ndev->dev.parent, "open_candev() failed %d\n", retval);
netdev_err(ndev, "open_candev() failed %d\n", retval);
goto err_open_candev;
}

Expand Down

0 comments on commit 435b4ef

Please sign in to comment.