Skip to content

Commit

Permalink
ethernet: moxa: fix incorrect placement of __initdata tag
Browse files Browse the repository at this point in the history
__initdata tag should be placed between the variable name and equal
sign for the variable to be placed in the intended .init.data section.

In this particular case __initdata is incorrect as moxart_mac_driver
can be used after the driver gets initialized.

Also while at it static-ize moxart_mac_driver.

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Bartlomiej Zolnierkiewicz authored and David S. Miller committed Oct 1, 2013
1 parent 3da812d commit 437a3ae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/moxa/moxart_ether.c
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ static const struct of_device_id moxart_mac_match[] = {
{ }
};

struct __initdata platform_driver moxart_mac_driver = {
static struct platform_driver moxart_mac_driver = {
.probe = moxart_mac_probe,
.remove = moxart_remove,
.driver = {
Expand Down

0 comments on commit 437a3ae

Please sign in to comment.