Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 326179
b: refs/heads/master
c: 79831fd
h: refs/heads/master
i:
  326177: ac76a12
  326175: 75152c3
v: v3
  • Loading branch information
Guenter Roeck committed Sep 24, 2012
1 parent 94f7bc7 commit 441d43e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: effb8ab114f7ed574f3c033dac642cd2c4ae0021
refs/heads/master: 79831fd4e0820bdc882d08707e4650ed4dfff3b8
15 changes: 5 additions & 10 deletions trunk/drivers/hwmon/mcp3021.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,25 +103,23 @@ static int mcp3021_probe(struct i2c_client *client,
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
return -ENODEV;

data = kzalloc(sizeof(struct mcp3021_data), GFP_KERNEL);
data = devm_kzalloc(&client->dev, sizeof(struct mcp3021_data),
GFP_KERNEL);
if (!data)
return -ENOMEM;

i2c_set_clientdata(client, data);

if (client->dev.platform_data) {
data->vdd = *(u32 *)client->dev.platform_data;
if (data->vdd > MCP3021_VDD_MAX ||
data->vdd < MCP3021_VDD_MIN) {
err = -EINVAL;
goto exit_free;
}
if (data->vdd > MCP3021_VDD_MAX || data->vdd < MCP3021_VDD_MIN)
return -EINVAL;
} else
data->vdd = MCP3021_VDD_REF;

err = sysfs_create_file(&client->dev.kobj, &dev_attr_in0_input.attr);
if (err)
goto exit_free;
return err;

data->hwmon_dev = hwmon_device_register(&client->dev);
if (IS_ERR(data->hwmon_dev)) {
Expand All @@ -133,8 +131,6 @@ static int mcp3021_probe(struct i2c_client *client,

exit_remove:
sysfs_remove_file(&client->dev.kobj, &dev_attr_in0_input.attr);
exit_free:
kfree(data);
return err;
}

Expand All @@ -144,7 +140,6 @@ static int mcp3021_remove(struct i2c_client *client)

hwmon_device_unregister(data->hwmon_dev);
sysfs_remove_file(&client->dev.kobj, &dev_attr_in0_input.attr);
kfree(data);

return 0;
}
Expand Down

0 comments on commit 441d43e

Please sign in to comment.