Skip to content

Commit

Permalink
V4L/DVB (6830): cx88-blackbird: remove unnecessary encoder unmute
Browse files Browse the repository at this point in the history
Remove the unnecessary BLACKBIRD_UNMUTE calls to the mpeg encoder in
cx88-blackbird.c

The encoder is never muted, hence unmuting should then only be necessary
once after hardware initialization.

I tested this from warm boots and cold boots (with long power down time
to ensure the sram in the chip is emptied), and found that after the
firmware upload the encoder is apparently not muted, making the unmutes
unnecessary.

Signed-off-by: Jelle Foks <jelle@foks.8m.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Jelle Foks authored and Mauro Carvalho Chehab committed Jan 25, 2008
1 parent e21a5c6 commit 4423a9a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/media/video/cx88/cx88-blackbird.c
Original file line number Diff line number Diff line change
Expand Up @@ -610,9 +610,6 @@ static int blackbird_start_codec(struct file *file, void *priv)
/* unmute audio source */
cx_clear(AUD_VOL_CTL, (1 << 6));

blackbird_api_cmd(dev, CX2341X_ENC_MUTE_VIDEO, 1, 0, BLACKBIRD_UNMUTE);
blackbird_api_cmd(dev, CX2341X_ENC_MUTE_AUDIO, 1, 0, BLACKBIRD_UNMUTE);

blackbird_api_cmd(dev, CX2341X_ENC_REFRESH_INPUT, 0,0);

/* initialize the video input */
Expand Down

0 comments on commit 4423a9a

Please sign in to comment.