Skip to content

Commit

Permalink
[PATCH] isdn4linux: Siemens Gigaset drivers: remove private version o…
Browse files Browse the repository at this point in the history
…f __skb_put()

With Hansjoerg Lipp <hjlipp@web.de>

Remove the private version of __skb_put() from the Siemens Gigaset drivers.

Signed-off-by: Hansjoerg Lipp <hjlipp@web.de>
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Tilman Schmidt authored and Linus Torvalds committed Apr 11, 2006
1 parent abfd1dc commit 443e1f4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 21 deletions.
5 changes: 2 additions & 3 deletions drivers/isdn/gigaset/asyncdata.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,7 @@ static inline int hdlc_loop(unsigned char c, unsigned char *src, int numbytes,
inputstate |= INS_skip_frame;
break;
}
*gigaset_skb_put_quick(skb, 1) = c;
/* *__skb_put (skb, 1) = c; */
*__skb_put(skb, 1) = c;
fcs = crc_ccitt_byte(fcs, c);
}

Expand Down Expand Up @@ -303,7 +302,7 @@ static inline int iraw_loop(unsigned char c, unsigned char *src, int numbytes,
inputstate |= INS_skip_frame;
break;
}
*gigaset_skb_put_quick(skb, 1) = gigaset_invtab[c];
*__skb_put(skb, 1) = gigaset_invtab[c];
}

if (unlikely(!numbytes))
Expand Down
17 changes: 0 additions & 17 deletions drivers/isdn/gigaset/gigaset.h
Original file line number Diff line number Diff line change
Expand Up @@ -852,23 +852,6 @@ static inline void gigaset_bchannel_up(struct bc_state *bcs)
/* handling routines for sk_buff */
/* ============================= */

/* private version of __skb_put()
* append 'len' bytes to the content of 'skb', already knowing that the
* existing buffer can accomodate them
* returns a pointer to the location where the new bytes should be copied to
* This function does not take any locks so it must be called with the
* appropriate locks held only.
*/
static inline unsigned char *gigaset_skb_put_quick(struct sk_buff *skb,
unsigned int len)
{
unsigned char *tmp = skb->tail;
/*SKB_LINEAR_ASSERT(skb);*/ /* not needed here */
skb->tail += len;
skb->len += len;
return tmp;
}

/* pass received skb to LL
* Warning: skb must not be accessed anymore!
*/
Expand Down
2 changes: 1 addition & 1 deletion drivers/isdn/gigaset/isocdata.c
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ static inline void hdlc_putbyte(unsigned char c, struct bc_state *bcs)
bcs->skb = NULL;
return;
}
*gigaset_skb_put_quick(bcs->skb, 1) = c;
*__skb_put(bcs->skb, 1) = c;
}

/* hdlc_flush
Expand Down

0 comments on commit 443e1f4

Please sign in to comment.