Skip to content

Commit

Permalink
USB: sisusbvga: no unnecessary GFP_ATOMIC
Browse files Browse the repository at this point in the history
If a driver can wait on an event, it can also use GFP_KERNEL.

Signed-off-by: Oliver Neukum <neukum@b1-systems.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Oliver Neukum authored and Greg Kroah-Hartman committed Mar 2, 2010
1 parent 3756c7c commit 444dc54
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/misc/sisusbvga/sisusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ sisusb_bulkout_msg(struct sisusb_usb_data *sisusb, int index, unsigned int pipe,
sisusb->urbstatus[index] |= SU_URB_BUSY;

/* Submit URB */
retval = usb_submit_urb(urb, GFP_ATOMIC);
retval = usb_submit_urb(urb, GFP_KERNEL);

/* If OK, and if timeout > 0, wait for completion */
if ((retval == 0) && timeout) {
Expand Down Expand Up @@ -306,7 +306,7 @@ sisusb_bulkin_msg(struct sisusb_usb_data *sisusb, unsigned int pipe, void *data,
urb->actual_length = 0;

sisusb->completein = 0;
retval = usb_submit_urb(urb, GFP_ATOMIC);
retval = usb_submit_urb(urb, GFP_KERNEL);
if (retval == 0) {
wait_event_timeout(sisusb->wait_q, sisusb->completein, timeout);
if (!sisusb->completein) {
Expand Down

0 comments on commit 444dc54

Please sign in to comment.