Skip to content

Commit

Permalink
ACPI: call acpi_power_init() explicitly rather than as initcall
Browse files Browse the repository at this point in the history
This patch makes acpi_init() call acpi_power_init() directly.
Previously, both were subsys_initcalls.  acpi_power_init()
must happen after acpi_init(), and it's better to call it
explicitly rather than rely on link ordering.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
CC: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Len Brown committed Mar 27, 2009
1 parent a5f820f commit 4451537
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
1 change: 1 addition & 0 deletions drivers/acpi/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -881,6 +881,7 @@ static int __init acpi_init(void)

acpi_scan_init();
acpi_ec_init();
acpi_power_init();
return result;
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ int acpi_scan_init(void);
/* --------------------------------------------------------------------------
Power Resource
-------------------------------------------------------------------------- */

int acpi_power_init(void);
int acpi_device_sleep_wake(struct acpi_device *dev,
int enable, int sleep_state, int dev_state);
int acpi_enable_wakeup_device_power(struct acpi_device *dev, int sleep_state);
Expand Down
8 changes: 1 addition & 7 deletions drivers/acpi/power.c
Original file line number Diff line number Diff line change
Expand Up @@ -773,14 +773,10 @@ static int acpi_power_resume(struct acpi_device *device)
return 0;
}

static int __init acpi_power_init(void)
int __init acpi_power_init(void)
{
int result = 0;


if (acpi_disabled)
return 0;

INIT_LIST_HEAD(&acpi_power_resource_list);

acpi_power_dir = proc_mkdir(ACPI_POWER_CLASS, acpi_root_dir);
Expand All @@ -795,5 +791,3 @@ static int __init acpi_power_init(void)

return 0;
}

subsys_initcall(acpi_power_init);

0 comments on commit 4451537

Please sign in to comment.