Skip to content

Commit

Permalink
net: move am79c961's probe function to .devinit.text
Browse files Browse the repository at this point in the history
A pointer to am79c961_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Uwe Kleine-König authored and David S. Miller committed Feb 12, 2010
1 parent 2bec5a3 commit 447d8c2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/arm/am79c961a.c
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ static const struct net_device_ops am79c961_netdev_ops = {
#endif
};

static int __init am79c961_probe(struct platform_device *pdev)
static int __devinit am79c961_probe(struct platform_device *pdev)
{
struct resource *res;
struct net_device *dev;
Expand Down

0 comments on commit 447d8c2

Please sign in to comment.