Skip to content

Commit

Permalink
ipv6/mcast: join error paths using goto
Browse files Browse the repository at this point in the history
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ilpo Järvinen authored and David S. Miller committed Dec 15, 2008
1 parent 5ce1bbb commit 448eb71
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions net/ipv6/mcast.c
Original file line number Diff line number Diff line change
Expand Up @@ -303,20 +303,23 @@ static struct inet6_dev *ip6_mc_find_dev(struct net *net,
dev = dev_get_by_index(net, ifindex);

if (!dev)
return NULL;
goto nodev;
idev = in6_dev_get(dev);
if (!idev) {
dev_put(dev);
return NULL;
}
if (!idev)
goto release;
read_lock_bh(&idev->lock);
if (idev->dead) {
read_unlock_bh(&idev->lock);
in6_dev_put(idev);
dev_put(dev);
return NULL;
}
if (idev->dead)
goto unlock_release;

return idev;

unlock_release:
read_unlock_bh(&idev->lock);
in6_dev_put(idev);
release:
dev_put(dev);
nodev:
return NULL;
}

void ipv6_sock_mc_close(struct sock *sk)
Expand Down

0 comments on commit 448eb71

Please sign in to comment.