Skip to content

Commit

Permalink
svc: Remove unnecessary call to svc_sock_enqueue
Browse files Browse the repository at this point in the history
The svc_tcp_accept function calls svc_sock_enqueue after setting the
SK_CONN bit. This doesn't actually do anything because the SK_BUSY bit
is still set. The call is unnecessary anyway because the generic code in
svc_recv calls svc_sock_received after calling the accept function.

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
Acked-by: Neil Brown <neilb@suse.de>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Greg Banks <gnb@sgi.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
Tom Tucker authored and J. Bruce Fields committed Feb 1, 2008
1 parent 38a417c commit 44a6995
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion net/sunrpc/svcsock.c
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,6 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt *xprt)
}

set_bit(SK_CONN, &svsk->sk_flags);
svc_sock_enqueue(svsk);

err = kernel_getpeername(newsock, sin, &slen);
if (err < 0) {
Expand Down

0 comments on commit 44a6995

Please sign in to comment.