Skip to content

Commit

Permalink
V4L/DVB: ds3000: fix divide-by-zero error in ds3000_read_snr()
Browse files Browse the repository at this point in the history
Fix a divide-by-zero error in ds3000's ds3000_read_snr(), when getting
a very low signal reading (dvbs2_signal_reading >= 1). This prevents
some nasty EIPs when running szap-s2 with a very low signal strength.

Signed-off-by: Nicolas Noirbent <nicolas.noirbent@smartjog.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Nicolas Noirbent authored and Mauro Carvalho Chehab committed May 19, 2010
1 parent b4bc3dc commit 450df22
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/dvb/frontends/ds3000.c
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ static int ds3000_read_snr(struct dvb_frontend *fe, u16 *snr)
(ds3000_readreg(state, 0x8d) << 4);
dvbs2_signal_reading = ds3000_readreg(state, 0x8e);
tmp = dvbs2_signal_reading * dvbs2_signal_reading >> 1;
if (dvbs2_signal_reading == 0) {
if (tmp == 0) {
*snr = 0x0000;
return 0;
}
Expand Down

0 comments on commit 450df22

Please sign in to comment.