Skip to content

Commit

Permalink
ftrace: irqsoff tracer incorrect reset
Browse files Browse the repository at this point in the history
Impact: fix to irqsoff tracer output

In converting to the new start / stop ftrace handling, the irqsoff
tracer start called the irqsoff reset function. irqsoff tracer is
not the same as the other traces, and it resets the buffers while
searching for the longest latency.

The reset that the irqsoff stop method calls disables the function
tracing. That means that, by starting the tracer, the function
tracer is disabled incorrectly.

This patch simply removes the call to reset which keeps the function
tracing enabled. Reset is not needed for the irqsoff stop method.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Steven Rostedt authored and Ingo Molnar committed Nov 8, 2008
1 parent e168e05 commit 4519317
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion kernel/trace/trace_irqsoff.c
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,6 @@ static void irqsoff_tracer_ctrl_update(struct trace_array *tr)

static void irqsoff_tracer_start(struct trace_array *tr)
{
irqsoff_tracer_reset(tr);
tracer_enabled = 1;
save_tracer_enabled = 1;
}
Expand Down

0 comments on commit 4519317

Please sign in to comment.